From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gzjjgod@gmail.com>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 274FE431FBF
	for <notmuch@notmuchmail.org>; Sat, 21 Nov 2009 20:31:55 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id h+ZqC4X8L51H for <notmuch@notmuchmail.org>;
	Sat, 21 Nov 2009 20:31:54 -0800 (PST)
Received: from mail-pw0-f51.google.com (mail-pw0-f51.google.com
	[209.85.160.51])
	by olra.theworths.org (Postfix) with ESMTP id 67D8C431FAE
	for <notmuch@notmuchmail.org>; Sat, 21 Nov 2009 20:31:54 -0800 (PST)
Received: by pwj10 with SMTP id 10so2820080pwj.30
	for <notmuch@notmuchmail.org>; Sat, 21 Nov 2009 20:31:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type;
	bh=g0aERYXp+a4JRD7+bGGkLKmuSUfo/WmEp8olWAjrTW8=;
	b=QZaQzVy5kmwNRYq17g4R1yS2cRHSEY8NxFNPcUAvupwBF/RNG3H6DHWnd9QbB3C7CY
	68XOcw2CdL3GZ7Zpx35JPyv47cwfa3uruEQbWFGkdy561Yi9czhb534+tBYynd6nMDIp
	+qOdM/O/+toZ1AD2F+GUbirKvlSaruKGwxUf0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=x+GYJ9KCzSzxI5UQFagOSDTerW/tRqMBsWxMFL/I2cKUiC7siGpw7gURG9ByoWQV4q
	6bDzMQ/MaSFh90FvLaAxgx2J9pyxzGjkXvD2cO5YkIBbWWiOLFknkKsTx2LnxQo990Q5
	1ms56OlGDbyFNAvUZ0gD7U2lXWgOAQLuLhMVg=
MIME-Version: 1.0
Received: by 10.115.115.14 with SMTP id s14mr5288656wam.189.1258864313952; 
	Sat, 21 Nov 2009 20:31:53 -0800 (PST)
In-Reply-To: <86pr7b9os2.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
References: <1258859256-33197-1-git-send-email-gzjjgod@gmail.com>
	<86pr7b9os2.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
Date: Sun, 22 Nov 2009 12:31:53 +0800
Message-ID: <ddd65cda0911212031v3dfead06x7ca054cebb7c5e34@mail.gmail.com>
From: Jjgod Jiang <gzjjgod@gmail.com>
To: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
Content-Type: text/plain; charset=UTF-8
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] Mac OS X compatibility fixes
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Nov 2009 04:31:55 -0000

Hi Alex,

On Sun, Nov 22, 2009 at 12:17 PM, Alexander Botero-Lowry
<alex.boterolowry@gmail.com> wrote:
>> +#ifdef __APPLE__
> Not awesome.
>
> This should be done in a capabilites way, for example strndup was added
> to FreeBSD in 7.2 (which is this current release of the 7 line), and so
> for older versions of FreeBSD strndup will be needed. getdelim() and
> getline() came in FreeBSD 8, so they'll be needed for the entire 7 line.
> So Instead of just assuming __APPLE__ this should be done by determing
> if the symbols are generally needed.

The problem is that notmuch does not have a fully functional configure
process yet, Carl did mention Makefile.local, but it seems this file is
not generated by configure right now. (No config.h either.)

I will be happy to fix my patch if such facility (like
AC_CHECK_FUNCS([getline])) exists.

- Jiang