From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: [PATCH v2 3/6] emacs: use new tag change helper to mark messages as replied
Date: Thu, 6 Sep 2012 18:32:39 +0300 [thread overview]
Message-ID: <db3d1f28f4bb4444a0b913236fd05aed0055c6d3.1346945257.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1346945257.git.jani@nikula.org>
In-Reply-To: <cover.1346945257.git.jani@nikula.org>
Clarify documentation while at it.
---
emacs/notmuch-message.el | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el
index 3798046..4dc4883 100644
--- a/emacs/notmuch-message.el
+++ b/emacs/notmuch-message.el
@@ -23,14 +23,16 @@
(require 'notmuch-tag)
(require 'notmuch-mua)
-(defcustom notmuch-message-replied-tags '("replied")
- "Tags to be automatically added to or removed from a message when it is replied to.
-Any tag in the list will be added to a replied message or,
-if it is prefaced with a \"-\", removed.
+(defcustom notmuch-message-replied-tags '("+replied")
+ "List of tag changes to apply to a message when it has been replied to.
+
+Tags starting with \"+\" (or not starting with either \"+\" or
+\"-\") in the list will be added, and tags starting with \"-\"
+will be removed from the message being replied to.
For example, if you wanted to add a \"replied\" tag and remove
-the \"inbox\" and \"todo\", you would set
- (\"replied\" \"-inbox\" \"-todo\"\)"
+the \"inbox\" and \"todo\" tags, you would set:
+ (\"+replied\" \"-inbox\" \"-todo\"\)"
:type '(repeat string)
:group 'notmuch-send)
@@ -38,14 +40,8 @@ the \"inbox\" and \"todo\", you would set
;; get the in-reply-to header and parse it for the message id.
(let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To"))))
(when (and notmuch-message-replied-tags rep)
- ;; add a "+" to any tag that is doesn't already begin with a "+"
- ;; or "-"
- (let ((tags (mapcar (lambda (str)
- (if (not (string-match "^[+-]" str))
- (concat "+" str)
- str))
- notmuch-message-replied-tags)))
- (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) tags)))))
+ (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep)))
+ (notmuch-tag-change-list notmuch-message-replied-tags)))))
(add-hook 'message-send-hook 'notmuch-message-mark-replied)
--
1.7.9.5
next prev parent reply other threads:[~2012-09-06 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 15:32 [PATCH v2 0/6] emacs: customization for tag changes on archive Jani Nikula
2012-09-06 15:32 ` [PATCH v2 1/6] emacs: add helper for tag change list manipulation Jani Nikula
2012-09-06 15:32 ` [PATCH v2 2/6] emacs: fix notmuch-message-replied-tags defcustom type Jani Nikula
2012-09-06 15:32 ` Jani Nikula [this message]
2012-09-06 15:32 ` [PATCH v2 4/6] emacs: add support for custom tag changes on message/thread archive Jani Nikula
2012-09-06 15:32 ` [PATCH v2 5/6] emacs: add support for reversing notmuch-search-archive-thread tag changes Jani Nikula
2012-09-06 15:32 ` [PATCH v2 6/6] emacs: add support for reversing notmuch-show-mark-read " Jani Nikula
2012-09-07 7:27 ` [PATCH v2 0/6] emacs: customization for tag changes on archive Tomi Ollila
2012-09-19 11:14 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db3d1f28f4bb4444a0b913236fd05aed0055c6d3.1346945257.git.jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).