From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 9E4B56DE00E6 for ; Sat, 8 Sep 2018 02:22:42 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.299 X-Spam-Level: X-Spam-Status: No, score=0.299 tagged_above=-999 required=5 tests=[AWL=-0.143, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.211, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hkYX2tGpInVS for ; Sat, 8 Sep 2018 02:22:41 -0700 (PDT) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by arlo.cworth.org (Postfix) with ESMTPS id D5DA86DE00D1 for ; Sat, 8 Sep 2018 02:22:40 -0700 (PDT) Received: by mail-wr1-f68.google.com with SMTP id e1-v6so8043008wrt.3 for ; Sat, 08 Sep 2018 02:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=5gBfoDuAcYi9WRoF5j6uQCkqDqDc32zbL2A86wAoJH8=; b=DRbWYYG4P3WawqMhaXh6W7UFxKhfMAaAmiw0o50lzfoCbG4Sed5QtqoP8F/6dmaVSQ OjYSw4WQ+hejLb3UbjnRLbtJn13GKrSvtBRfSbc7ZDWeIlb7Wq2Y94cxbS4e898URFON LSHb10Gxq2lguYmIBhYsTfL1nESce8C/oECkOlE1BY02A4acTVUZyv1jxv/rXbMkjQCP FbOT+DThESI85l0SEzaP8vTGWi4jX4uVspN1EKWNj6/f9rB4d9OFgI7T9NVOE5noUFs8 6Nn2pt+JCOx+8P93mA2gZiPCHGl8eoq0Og474yLbUzd2EHz4knz2EfhLMqhAFg08f2UU rEZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=5gBfoDuAcYi9WRoF5j6uQCkqDqDc32zbL2A86wAoJH8=; b=g+CQAZEfGpQLUEvSKrGegh12uf7+3SGyzfwowclq3smDyM+23SuyZMTJxZZR2QcItY 8yliWSWSZE7CP1akehER1HApGdo7UM2cxMpUgS1R5SiwCTZQL25uld6zdRZymMtY1X3I thRMHYihIWaaBZYVbTthmsu2M1sdsAll27PArMU5baKnGdHItb/wPWgscjvaONuFCFOY MTQCigiGAQ2ZhSpp9flcDak+2RE5UOqVgWxcfIZ+v+ZeN19Q8QUlylXum+AR/dVbYI8F bWZswK6RcnJ4f8YM1dvC9ARXoPdD4oXK6jFpiMyTyq8yo0NBm1dE5Yn8gxF7MU3Pq2L9 Oq8w== X-Gm-Message-State: APzg51CjRDSeEm4i+4wxul2nHAk9qfvTC7LeXAZxnHW3RZw5okI/HtiO 9X1ZRVqlGV+/EDcJJL1tBFFQ9sYKJ5Y= X-Google-Smtp-Source: ANB0VdYls1h0IoJuE57fIEvww61wUt+XH00jhshcBtih0V5rUm7MvrLlytuGTG5vStuZlehwIjpr/Q== X-Received: by 2002:adf:f4ce:: with SMTP id h14-v6mr9471513wrp.259.1536398556847; Sat, 08 Sep 2018 02:22:36 -0700 (PDT) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id e7-v6sm13151449wru.46.2018.09.08.02.22.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Sep 2018 02:22:35 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id d72f34f8; Sat, 8 Sep 2018 09:22:34 +0000 (UTC) To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v1 1/2] test: Absolute and relative directory paths. In-Reply-To: <87sh2kj1kd.fsf@tethera.net> References: <20180825115756.24148-1-dme@dme.org> <20180825115756.24148-2-dme@dme.org> <87sh2kj1kd.fsf@tethera.net> X-HGTTG: constant-mown From: David Edmondson Date: Sat, 08 Sep 2018 10:22:34 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Sep 2018 09:22:42 -0000 On Friday, 2018-09-07 at 21:05:38 -03, David Bremner wrote: > David Edmondson writes: > >> --- >> test/T030-config.sh | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/test/T030-config.sh b/test/T030-config.sh >> index e91c3659..f36695c6 100755 >> --- a/test/T030-config.sh >> +++ b/test/T030-config.sh >> @@ -99,4 +99,14 @@ test_expect_equal "$(notmuch --config=alt-config-link config get user.name)" \ >> test_begin_subtest "Writing config file through symlink follows symlink" >> test_expect_equal "$(readlink alt-config-link)" "alt-config" >> >> +test_begin_subtest "Absolute database path returned" >> +notmuch config set database.path ${HOME}/Maildir >> +test_expect_equal "$(notmuch config get database.path)" \ >> + "${HOME}/Maildir" >> + >> +test_begin_subtest "Relative database path properly expanded" >> +notmuch config set database.path Maildir >> +test_expect_equal "$(notmuch config get database.path)" \ >> + "${HOME}/Maildir" >> + >> test_done >> -- > > We want the test suite to pass after every commit, so you need to either > squash the second test into the next commit, or mark it with > test_subtest_known_broken. I'm fine with either option. Would you be happy with me just re-arranging the order, so that the test came after? dme. -- Sorry I'm not home right now, I'm walking into spiderwebs.