unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Edmondson <dme@dme.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v1 1/2] test: Absolute and relative directory paths.
Date: Sat, 08 Sep 2018 10:22:34 +0100	[thread overview]
Message-ID: <cuny3ccmjhh.fsf@constant-mown.hh.sledj.net> (raw)
In-Reply-To: <87sh2kj1kd.fsf@tethera.net>

On Friday, 2018-09-07 at 21:05:38 -03, David Bremner wrote:

> David Edmondson <dme@dme.org> writes:
>
>> ---
>>  test/T030-config.sh | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/test/T030-config.sh b/test/T030-config.sh
>> index e91c3659..f36695c6 100755
>> --- a/test/T030-config.sh
>> +++ b/test/T030-config.sh
>> @@ -99,4 +99,14 @@ test_expect_equal "$(notmuch --config=alt-config-link config get user.name)" \
>>  test_begin_subtest "Writing config file through symlink follows symlink"
>>  test_expect_equal "$(readlink alt-config-link)" "alt-config"
>>  
>> +test_begin_subtest "Absolute database path returned"
>> +notmuch config set database.path ${HOME}/Maildir
>> +test_expect_equal "$(notmuch config get database.path)" \
>> +		  "${HOME}/Maildir"
>> +
>> +test_begin_subtest "Relative database path properly expanded"
>> +notmuch config set database.path Maildir
>> +test_expect_equal "$(notmuch config get database.path)" \
>> +		  "${HOME}/Maildir"
>> +
>>  test_done
>> -- 
>
> We want the test suite to pass after every commit, so you need to either
> squash the second test into the next commit, or mark it with
> test_subtest_known_broken. I'm fine with either option.

Would you be happy with me just re-arranging the order, so that the test
came after?

dme.
-- 
Sorry I'm not home right now, I'm walking into spiderwebs.

  reply	other threads:[~2018-09-08  9:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-25 11:57 [PATCH v1 0/2] Interpret a directory path without a leading slash as relative to $HOME David Edmondson
2018-08-25 11:57 ` [PATCH v1 1/2] test: Absolute and relative directory paths David Edmondson
2018-09-08  0:05   ` David Bremner
2018-09-08  9:22     ` David Edmondson [this message]
2018-09-08 10:27       ` David Bremner
2018-08-25 11:57 ` [PATCH v1 2/2] notmuch: Database paths without a leading / are relative to $HOME David Edmondson
2018-09-08  0:10   ` David Bremner
2018-09-08  9:22     ` David Edmondson
2018-09-08 10:28       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cuny3ccmjhh.fsf@constant-mown.hh.sledj.net \
    --to=dme@dme.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).