* [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
@ 2012-01-30 16:52 David Edmondson
2012-01-31 5:25 ` Jameson Graef Rollins
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: David Edmondson @ 2012-01-30 16:52 UTC (permalink / raw)
To: notmuch
The blank line doesn't really change position, but is now considered
to be part of the body rather than part of the headers. This means
that it is visible when the body is visible rather than when the
headers are visible.
---
I'm interested in getting feedback on this.
Unless you run with `notmuch-message-headers-visible' set to `nil' or
regularly toggle header visibility, you probably don't care.
emacs/notmuch-show.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 84ac624..73f73d4 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -854,8 +854,6 @@ current buffer, if possible."
;; compatible with the existing implementation. This just sets it
;; to after the first header.
(notmuch-show-insert-headers headers)
- ;; Headers should include a blank line (backwards compatibility).
- (insert "\n")
(save-excursion
(goto-char content-start)
;; If the subject of this message is the same as that of the
@@ -870,6 +868,8 @@ current buffer, if possible."
(setq notmuch-show-previous-subject bare-subject)
(setq body-start (point-marker))
+ ;; A blank line between the headers and the body.
+ (insert "\n")
(notmuch-show-insert-body msg (plist-get msg :body) depth)
;; Ensure that the body ends with a newline.
(unless (bolp)
--
1.7.8.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
2012-01-30 16:52 [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body David Edmondson
@ 2012-01-31 5:25 ` Jameson Graef Rollins
2012-01-31 10:32 ` David Edmondson
2012-01-31 11:41 ` Dmitry Kurochkin
2012-02-04 12:39 ` David Bremner
2 siblings, 1 reply; 6+ messages in thread
From: Jameson Graef Rollins @ 2012-01-31 5:25 UTC (permalink / raw)
To: David Edmondson, notmuch
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
This definitely makes sense. I rarely hide headers anymore, but I never
liked that the separation between the headers and the body went away
when the headers are hidden. +1.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
2012-01-31 5:25 ` Jameson Graef Rollins
@ 2012-01-31 10:32 ` David Edmondson
2012-01-31 11:34 ` Tomi Ollila
0 siblings, 1 reply; 6+ messages in thread
From: David Edmondson @ 2012-01-31 10:32 UTC (permalink / raw)
To: Jameson Graef Rollins, notmuch
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> > The blank line doesn't really change position, but is now considered
> > to be part of the body rather than part of the headers. This means
> > that it is visible when the body is visible rather than when the
> > headers are visible.
>
> This definitely makes sense. I rarely hide headers anymore, but I never
> liked that the separation between the headers and the body went away
> when the headers are hidden. +1.
Any objections to changing this?
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
2012-01-31 10:32 ` David Edmondson
@ 2012-01-31 11:34 ` Tomi Ollila
0 siblings, 0 replies; 6+ messages in thread
From: Tomi Ollila @ 2012-01-31 11:34 UTC (permalink / raw)
To: David Edmondson, Jameson Graef Rollins, notmuch
On Tue, 31 Jan 2012 10:32:12 +0000, David Edmondson <dme@dme.org> wrote:
> On Mon, 30 Jan 2012 21:25:19 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> > > The blank line doesn't really change position, but is now considered
> > > to be part of the body rather than part of the headers. This means
> > > that it is visible when the body is visible rather than when the
> > > headers are visible.
> >
> > This definitely makes sense. I rarely hide headers anymore, but I never
> > liked that the separation between the headers and the body went away
> > when the headers are hidden. +1.
>
> Any objections to changing this?
+1 for changing this.
Tomi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
2012-01-30 16:52 [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body David Edmondson
2012-01-31 5:25 ` Jameson Graef Rollins
@ 2012-01-31 11:41 ` Dmitry Kurochkin
2012-02-04 12:39 ` David Bremner
2 siblings, 0 replies; 6+ messages in thread
From: Dmitry Kurochkin @ 2012-01-31 11:41 UTC (permalink / raw)
To: David Edmondson, notmuch
On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
> ---
>
> I'm interested in getting feedback on this.
>
> Unless you run with `notmuch-message-headers-visible' set to `nil' or
> regularly toggle header visibility, you probably don't care.
>
+1
Regards,
Dmitry
> emacs/notmuch-show.el | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 84ac624..73f73d4 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -854,8 +854,6 @@ current buffer, if possible."
> ;; compatible with the existing implementation. This just sets it
> ;; to after the first header.
> (notmuch-show-insert-headers headers)
> - ;; Headers should include a blank line (backwards compatibility).
> - (insert "\n")
> (save-excursion
> (goto-char content-start)
> ;; If the subject of this message is the same as that of the
> @@ -870,6 +868,8 @@ current buffer, if possible."
> (setq notmuch-show-previous-subject bare-subject)
>
> (setq body-start (point-marker))
> + ;; A blank line between the headers and the body.
> + (insert "\n")
> (notmuch-show-insert-body msg (plist-get msg :body) depth)
> ;; Ensure that the body ends with a newline.
> (unless (bolp)
> --
> 1.7.8.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.
2012-01-30 16:52 [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body David Edmondson
2012-01-31 5:25 ` Jameson Graef Rollins
2012-01-31 11:41 ` Dmitry Kurochkin
@ 2012-02-04 12:39 ` David Bremner
2 siblings, 0 replies; 6+ messages in thread
From: David Bremner @ 2012-02-04 12:39 UTC (permalink / raw)
To: David Edmondson, notmuch
On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
pushed.
d
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-04 12:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-30 16:52 [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body David Edmondson
2012-01-31 5:25 ` Jameson Graef Rollins
2012-01-31 10:32 ` David Edmondson
2012-01-31 11:34 ` Tomi Ollila
2012-01-31 11:41 ` Dmitry Kurochkin
2012-02-04 12:39 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).