Re: [PATCH v2] emacs: Add support for saved search accelerators

[David Edmondson <dme@dme.org>]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Sat, May 10 2014, Aaron Ecay wrote:
> 2014ko maiatzak 8an, Mark Walters-ek idatzi zuen:
>>
>> Hi
>>
>> This version looks good to me.
>>
>> The only slight query I have is which key to bind it to: Austin used g
>> in notmuch-go and this uses j. Austin said on irc that he chose g
>> because it wasn't bound and matched gmail's shortcut.
>>
>> Personally I like j (as it starts fewer words than g) and given that we
>> don't match any of gmail's other bindings I don't think there is much
>> advantage to doing so in this case.
>
> All other things being equal, I’d prefer “j” here, but for different
> reasons.  “g” is the emacs-standard key to refresh or revert a buffer.
> In my personal customization file I bound “g” to
> notmuch-refresh-this-buffer in notmuch-(show/search)-mode-map long ago
> (and forgot this binding was not standard until reading above that g is
> not bound).  It’s probably better emacs citizenship to not use such a
> standard key for a different purpose.

+1, though I won't lose sleep.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 310 bytes --]