Re: feature request: fetch missing keys in the background

[David Edmondson <dme@dme.org>]

On Monday, 2018-09-03 at 18:21:32 +01, David Edmondson wrote:

> How about this patch?
>
> You'll need to set “notmuch-crypto-get-keys-asynchronously” to “t” to
> see any benefit.

Oops, and delete the old version of
“notmuch-crypto-sigstatus-error-callback” from just below the new one.

> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
> index fc2b5301..97396ba0 100644
> --- a/emacs/notmuch-crypto.el
> +++ b/emacs/notmuch-crypto.el
> @@ -43,6 +43,11 @@ mode."
>    :package-version '(notmuch . "0.25")
>    :group 'notmuch-crypto)
>  
> +(defcustom notmuch-crypto-get-keys-asynchronously nil
> +  "Retrieve gpg keys asynchronously."
> +  :type 'boolean
> +  :group 'notmuch-crypto)
> +
>  (defface notmuch-crypto-part-header
>    '((((class color)
>        (background dark))
> @@ -145,6 +150,36 @@ mode."
>  	(call-process epg-gpg-program nil t t "--list-keys" fingerprint))
>        (recenter -1))))
>  
> +(defun notmuch-crypto--async-key-sentinel (process event)
> +  (let ((status (process-status process))
> +	(exit-status (process-exit-status process)))
> +    (when (memq status '(exit signal))
> +      (message "Asynchronous GPG key retrieval %s."
> +	       (if (= exit-status 0)
> +		   "completed"
> +		 "failed")))))
> +
> +(defun notmuch-crypto-sigstatus-error-callback (button)
> +  (let* ((sigstatus (button-get button :notmuch-sigstatus))
> +	 (keyid (concat "0x" (plist-get sigstatus :keyid)))
> +	 (buffer (get-buffer-create "*notmuch-crypto-gpg-out*")))
> +    (if notmuch-crypto-get-keys-asynchronously
> +	(progn
> +	  (message "Getting the GPG key %s asynchronously..." keyid)
> +	  (make-process :name "notmuch GPG key retrieval"
> +		       :buffer buffer
> +		       :command (list epg-gpg-program "--recv-keys" keyid)
> +		       :sentinel #'notmuch-crypto--async-key-sentinel))
> +      (let ((window (display-buffer buffer t nil)))
> +	(with-selected-window window
> +	  (with-current-buffer buffer
> +	    (goto-char (point-max))
> +	    (call-process epg-gpg-program nil t t "--recv-keys" keyid)
> +	    (insert "\n")
> +	    (call-process epg-gpg-program nil t t "--list-keys" keyid))
> +	  (recenter -1))
> +	(notmuch-show-refresh-view)))))
> +
>  (defun notmuch-crypto-sigstatus-error-callback (button)
>    (let* ((sigstatus (button-get button :notmuch-sigstatus))
>  	 (keyid (concat "0x" (plist-get sigstatus :keyid)))
>
> dme.
> -- 
> For a long time I felt, without style and grace.

dme.
-- 
I'm not living in the real world, no more, no more.