From: David Edmondson <dme@dme.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/4 v42] test: Add more helpers for emacs tests.
Date: Tue, 24 Jan 2012 15:54:46 +0000 [thread overview]
Message-ID: <cunpqe9p03d.fsf@hotblack-desiato.hh.sledj.net> (raw)
In-Reply-To: <8762g1m7e9.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Tue, 24 Jan 2012 19:45:18 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> 1. rename notmuch-test-compare to notmuch-test-expect-equal
I'll change this.
> 2. move the top level equal check to the non-list branch
I'd rather not change this, though I'll write some commentary to explain
how things are.
> But both of these are subjective and minor, so I leave it to David to
> decide whether to change or ignore them. Otherwise, the patch looks
> good to me.
>
> While replying to this email, I noticed a trailing whitespace. I may
> have missed them in other patches. David, can you please check for
> trailing white spaces and clean them?
Yes.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2012-01-24 15:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 12:52 emacs based tests, version 3 David Edmondson
2012-01-17 12:52 ` [PATCH 1/4] test: Add `test_emacs_expect_t' David Edmondson
2012-01-17 13:09 ` Dmitry Kurochkin
2012-01-17 13:24 ` David Edmondson
2012-01-17 14:07 ` [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester David Edmondson
2012-01-17 14:07 ` [PATCH 2/3] test: Add `test_emacs_expect_t' David Edmondson
2012-01-17 14:26 ` Dmitry Kurochkin
2012-01-17 14:35 ` David Edmondson
2012-01-17 14:43 ` Dmitry Kurochkin
[not found] ` <87zkdmwfi7.fsf@gmail.com>
2012-01-17 15:09 ` David Edmondson
2012-01-18 9:09 ` Tomi Ollila
2012-01-18 14:55 ` Tomi Ollila
2012-01-19 9:59 ` David Edmondson
2012-01-19 10:32 ` Tomi Ollila
2012-01-19 10:42 ` David Edmondson
2012-01-19 11:01 ` Tomi Ollila
2012-01-19 12:54 ` [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester David Edmondson
2012-01-19 12:54 ` [PATCH 2/3] test: Add `test_emacs_expect_t' David Edmondson
2012-01-23 11:47 ` David Edmondson
2012-01-23 16:45 ` Dmitry Kurochkin
2012-01-19 12:54 ` [PATCH 3/3] test: Add address cleaning tests David Edmondson
2012-01-23 17:26 ` Dmitry Kurochkin
2012-01-23 16:32 ` [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester Dmitry Kurochkin
2012-01-17 14:07 ` [PATCH 3/3] test: Add address cleaning tests David Edmondson
2012-01-17 14:20 ` [PATCH 1/3] test: Don't return the result of checking for running emacs to the tester Dmitry Kurochkin
2012-01-17 14:37 ` David Edmondson
2012-01-17 14:51 ` Dmitry Kurochkin
2012-01-23 18:05 ` [PATCH 1/4 v42] " David Edmondson
2012-01-23 18:05 ` [PATCH 2/4 v42] test: Add `test_emacs_expect_t' David Edmondson
2012-01-24 15:24 ` Dmitry Kurochkin
2012-01-23 18:05 ` [PATCH 3/4 v42] test: Add more helpers for emacs tests David Edmondson
2012-01-24 15:45 ` Dmitry Kurochkin
2012-01-24 15:54 ` David Edmondson [this message]
2012-01-23 18:05 ` [PATCH 4/4 v42] test: Add address cleaning tests David Edmondson
2012-01-24 15:35 ` Dmitry Kurochkin
2012-01-24 15:20 ` [PATCH 1/4 v42] test: Don't return the result of checking for running emacs to the tester Dmitry Kurochkin
2012-01-24 16:14 ` [PATCH 0/4 v43] emacs test helpers David Edmondson
2012-01-24 16:14 ` [PATCH 1/4 v43] test: Don't return the result of checking for running emacs to the tester David Edmondson
2012-01-24 16:14 ` [PATCH 2/4 v43] test: Add `test_emacs_expect_t' David Edmondson
2012-01-24 16:14 ` [PATCH 3/4 v43] test: Add more helpers for emacs tests David Edmondson
2012-01-24 16:14 ` [PATCH 4/4 v43] test: Add address cleaning tests David Edmondson
2012-01-24 16:19 ` [PATCH 0/4 v43] emacs test helpers Dmitry Kurochkin
2012-01-24 20:13 ` Tomi Ollila
2012-01-25 11:33 ` David Bremner
2012-01-17 12:52 ` [PATCH 2/4] test: Add address cleaning tests David Edmondson
2012-01-17 13:11 ` Dmitry Kurochkin
2012-01-17 13:23 ` David Edmondson
2012-01-17 12:52 ` [PATCH 3/4] emacs: Avoid `mail-header-parse-address' in `notmuch-show-clean-address' David Edmondson
2012-01-17 12:52 ` [PATCH 4/4] emacs: Another special case for `notmuch-show-clean-address' David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cunpqe9p03d.fsf@hotblack-desiato.hh.sledj.net \
--to=dme@dme.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).