From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8A763431FAF for ; Thu, 26 Jan 2012 00:46:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q8+JIGwy2XeG for ; Thu, 26 Jan 2012 00:46:08 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 33EEE431FAE for ; Thu, 26 Jan 2012 00:46:08 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so280790wgb.2 for ; Thu, 26 Jan 2012 00:46:07 -0800 (PST) Received: by 10.180.81.35 with SMTP id w3mr1814721wix.10.1327567566973; Thu, 26 Jan 2012 00:46:06 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id l6sm4127151wiv.11.2012.01.26.00.46.05 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Jan 2012 00:46:05 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id DFBA29FD9F; Thu, 26 Jan 2012 08:46:03 +0000 (GMT) To: Dmitry Kurochkin , Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: add completion to "tag all" operation ("*" binding) In-Reply-To: <87wr8fqlpg.fsf@gmail.com> References: <1327540351-5249-1-git-send-email-dmitry.kurochkin@gmail.com> <20120126013727.GB1176@mit.edu> <87wr8fqlpg.fsf@gmail.com> User-Agent: Notmuch/0.11+114~g550724b (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 26 Jan 2012 08:46:00 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2012 08:46:15 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 26 Jan 2012 05:47:07 +0400, Dmitry Kurochkin wrote: > > > + ;; Perform some validation > > > + (let ((words action)) > > > + (when (null words) (error "No operation given")) > > > + (while words > > > + (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words)) > > > + (error "Action must be of the form `+thistag -that_tag'")) > > > + (setq words (cdr words)))) > >=20 > > This should really be a mapc or a dolist, but maybe that's for another > > patch. >=20 > Yes, I changed "this_tag" spelling in v2, but would prefer to leave > non-trivial changes in this code for another patch. If you were going to submit another patch then fine, but the chances are it will just get forgotten. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8hEsgACgkQaezQq/BJZRb7lQCcDunr5BSWhn05WUQ3DPccHNku jd8An3OIzrujNMKdFXJmBqzsfeXaNfO1 =nxTf -----END PGP SIGNATURE----- --=-=-=--