[PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

[PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

[Dmitry Kurochkin]

Recent changes in notmuch-show tagging introduced some code
duplication.  The patch cleanups and simplifies
`notmuch-show-archive-thread' function by using
`notmuch-show-tag-all', no longer used function are removed.  After
the change, `notmuch-show-archive-thread' function becomes symmetric
with `notmuch-show-archive-message'.

A side effect of these changes is that `notmuch-show-archive-thread'
no longer calls "notmuch tag" for each message in the thread.
---
 emacs/notmuch-show.el |   25 ++-----------------------
 1 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index faa9f9b..8199f56 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1598,26 +1598,6 @@ argument, hide all of the messages."
   (interactive)
   (backward-button 1))
 
-(defun notmuch-show-tag-thread-internal (tag &optional remove)
-  "Add tag to the current set of messages.
-
-If the remove switch is given, tags will be removed instead of
-added."
-  (goto-char (point-min))
-  (let ((op (if remove "-" "+")))
-    (loop do (notmuch-show-tag-message (concat op tag))
-	  until (not (notmuch-show-goto-message-next)))))
-
-(defun notmuch-show-add-tag-thread (tag)
-  "Add tag to all messages in the current thread."
-  (interactive)
-  (notmuch-show-tag-thread-internal tag))
-
-(defun notmuch-show-remove-tag-thread (tag)
-  "Remove tag from all messages in the current thread."
-  (interactive)
-  (notmuch-show-tag-thread-internal tag t))
-
 (defun notmuch-show-next-thread (&optional show-next)
   "Move to the next item in the search results, if any."
   (interactive "P")
@@ -1645,9 +1625,8 @@ being delivered to the same thread. It does not archive the
 entire thread, but only the messages shown in the current
 buffer."
   (interactive "P")
-  (if unarchive
-      (notmuch-show-add-tag-thread "inbox")
-    (notmuch-show-remove-tag-thread "inbox")))
+  (let ((op (if unarchive "+" "-")))
+    (notmuch-show-tag-all (concat op "inbox"))))
 
 (defun notmuch-show-archive-thread-then-next ()
   "Archive each message in thread, then show next thread from search."
-- 
1.7.9

Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

[Tomi Ollila]

On Wed,  8 Feb 2012 20:48:51 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Recent changes in notmuch-show tagging introduced some code
> duplication.  The patch cleanups and simplifies
> `notmuch-show-archive-thread' function by using
> `notmuch-show-tag-all', no longer used function are removed.  After
> the change, `notmuch-show-archive-thread' function becomes symmetric
> with `notmuch-show-archive-message'.
> 
> A side effect of these changes is that `notmuch-show-archive-thread'
> no longer calls "notmuch tag" for each message in the thread.
> ---

+1, works fine, is fast

Tomi

Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

[David Edmondson]

[-- Attachment #1: Type: text/plain, Size: 12 bytes --]

Looks good.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] emacs: cleanup and simplify `notmuch-show-archive-thread' and related functions

[David Bremner]

On Wed,  8 Feb 2012 20:48:51 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Recent changes in notmuch-show tagging introduced some code
> duplication.  The patch cleanups and simplifies
> `notmuch-show-archive-thread' function by using

pushed, 

d