From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qNacAgAMvmDWHAEAgWs5BA (envelope-from ) for ; Mon, 07 Jun 2021 14:07:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EFNtOf8LvmDsAQAAbx9fmQ (envelope-from ) for ; Mon, 07 Jun 2021 12:07:27 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C862E210AD for ; Mon, 7 Jun 2021 14:07:26 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 60AED29C43; Mon, 7 Jun 2021 08:07:19 -0400 (EDT) Received: from forward4-smtp.messagingengine.com (forward4-smtp.messagingengine.com [66.111.4.238]) by mail.notmuchmail.org (Postfix) with ESMTPS id 213F827185 for ; Mon, 7 Jun 2021 08:07:16 -0400 (EDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.nyi.internal (Postfix) with ESMTP id A004519403F6; Mon, 7 Jun 2021 08:07:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 07 Jun 2021 08:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=lknc43 HCUXusgjdji4MCsO3a1xM2elraZT70Fx6fLm4=; b=Dp41TKHxZIAJdzHIFfD+xj PBJ75EYnV+Dn87yvwfKQp16yqhJEJ+IqmoMg4qLCTwxZ0zmiIPsqV9pY3c6RurcS RWukvdhkc5cXb1i+Er07PySoeLIk/8mqFYuaRCn7i4/CdInxRZz/orRQCUYE3Bwj 4ZztGekT/DEJIDVMVAdnhXszVuqS3qcNYYkjHGcnfR6Y0GpdIbid9zmznJG6KREm TbqtYR9oCxJ8qNRwMyV3gUXGCdDqqTFFMfEEoaty9yBPHoWyBn4jatNZjTbgSPNE GTWCsHq1467IGuuHx7BHGvoxSnZ4fDjLkReaw7iKBceFG4BtCm6Oprp49r9G2dxg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtjedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvffujghfhfffkfggtgesthdtredttddttdenucfhrhhomhepffgrvhhiugcu gfgumhhonhgushhonhcuoegumhgvsegumhgvrdhorhhgqeenucggtffrrghtthgvrhhnpe fhkeeguedtvdegffffteehjedvjeeitefgfefgffdugeffffegudehgeetgeelkeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhgvsegumh gvrdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Jun 2021 08:07:13 -0400 (EDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id fc2fd741; Mon, 7 Jun 2021 12:07:12 +0000 (UTC) To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 2/2] emacs: Prefer email address over User ID when showing valid signature In-Reply-To: <20210527014459.3082888-2-dkg@fifthhorseman.net> References: <878s41ax6t.fsf@fifthhorseman.net> <20210527014459.3082888-1-dkg@fifthhorseman.net> <20210527014459.3082888-2-dkg@fifthhorseman.net> X-HGTTG: zarquon From: David Edmondson Date: Mon, 07 Jun 2021 13:07:12 +0100 Message-ID: MIME-Version: 1.0 Message-ID-Hash: 5HGMBJHFBCIFRABBHNPFL64NBB4CEKTX X-Message-ID-Hash: 5HGMBJHFBCIFRABBHNPFL64NBB4CEKTX X-MailFrom: dme@dme.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623067647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=CBDRKiBNnVIMy/nYbB1nlq1OP7rRDDThur4E7M1Vg0U=; b=Tiejz+sNHry4PQCY6W+eOqacLTtKUyAfmP8e7kRiD/y3lJD49jbHcAKPwkkG2QNv3NAAsg 972GnvnR86t8yu/PvaoyhmdT4/P99FvApc9hTakbD7xrnYtBewaPXGqHw2aL9b6C47MViE E54hMNzzxk/hgC5BvA5z32kzBt2ueWLmPTPSOyY9htLcg/bRFv17yNBv3MhfNtffUkOgxL oh9+5ebu0hx50tf7xI0VNam3LyHM4TNVeS7yGGZx3DNFJnu6hKqVRLG0bb4BWRecAoisIf KM80kxyZY9xq8hMAiKidpUsum7OTdbzCSbSD7IprcFWcb72S9SnRDmG3GAPQ5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623067647; a=rsa-sha256; cv=none; b=Dw9x3IP1tC8VCxt3oxdre4jIFip104T4oT1kc6/5+J4wjQ5UsLYYPwBdXC20mzgM8/Rtbn YdHPqKrhMFEU+YQ4BkQNEg3emHpzb7pgkXE4TjA95NDnNvsWuM1U7oEWPZgwiEE7+Rmvq0 4lp9ijzB9z5h08mUmC8R3MCwEtmF+C/Dbv1T9ReqacHtvPXH+2En/f88voRuuzaEDPwji+ S/eaN7vZrR/za9GLP0ZS680y57Gxx0gpUeOp/LrJXZNLfTgydborJ5roiHGgOXBBquQjOA 8ttrTEkHeeUh8caXIkpebBoRyJrSaF6WqGiB9MGof6w4s7/jni6GyJfENKG3XQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm3 header.b=Dp41TKHx; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm3 header.b=Dp41TKHx; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C862E210AD X-Spam-Score: -0.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: P9onTnhp/Vpd On Wednesday, 2021-05-26 at 21:44:59 -04, Daniel Kahn Gillmor wrote: > Most concrete verification steps are likely only taken on the e-mail > address in the first place, and e-mail addresses render more > intelligibly than arbitrary User IDs in the first place. > > Signed-off-by: Daniel Kahn Gillmor > --- > emacs/notmuch-crypto.el | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el > index db7cb75d..5c260a7a 100644 > --- a/emacs/notmuch-crypto.el > +++ b/emacs/notmuch-crypto.el > @@ -119,14 +119,19 @@ mode." > (cond > ((string= status "good") > (let ((fingerprint (concat "0x" (plist-get sigstatus :fingerprint))) > + (email (plist-get sigstatus :email)) > (userid (plist-get sigstatus :userid))) > - ;; If userid is present it has full or greater validity. > - (if userid > + ;; If email or userid are present, they have full or greater validity. > + (if email Could this not be something like: (when (or email userid) (setq label (concat "Good signature by: " (or email userid))) ... ) ? > (progn > - (setq label (concat "Good signature by: " userid)) > + (setq label (concat "Good signature by: " email)) > (setq face 'notmuch-crypto-signature-good)) > - (setq label (concat "Good signature by key: " fingerprint)) > - (setq face 'notmuch-crypto-signature-good-key)) > + (if userid > + (progn > + (setq label (concat "Good signature by: " userid)) > + (setq face 'notmuch-crypto-signature-good)) > + (setq label (concat "Good signature by key: " fingerprint)) > + (setq face 'notmuch-crypto-signature-good-key))) > (setq button-action 'notmuch-crypto-sigstatus-good-callback) > (setq help-msg (concat "Click to list key ID 0x" fingerprint ".")))) > ((string= status "error") > -- > 2.30.2 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org dme. -- If I could buy my reasoning, I'd pay to lose.