From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2OQyGhWSsV9/XQAA0tVLHw (envelope-from ) for ; Sun, 15 Nov 2020 20:39:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iOcpFhWSsV8bIwAA1q6Kng (envelope-from ) for ; Sun, 15 Nov 2020 20:39:49 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B009A9401D0 for ; Sun, 15 Nov 2020 20:39:45 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 62109270CC; Sun, 15 Nov 2020 15:39:35 -0500 (EST) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by mail.notmuchmail.org (Postfix) with ESMTPS id 9506E20315 for ; Sun, 15 Nov 2020 15:39:33 -0500 (EST) Received: by mail-wm1-x344.google.com with SMTP id c9so22001533wml.5 for ; Sun, 15 Nov 2020 12:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=RiCwtpNoox2f+/NHq1/7BxV+rr6wkgqDnJKgrk/kapg=; b=sRds2dfvR3LS6ce9pO1RVw51vjRzEsnaekruOddfHpEMrATxjHd75bgOR1dmAQGzmi lz6lQUNQCJcA91Xj8oWzmU7/Wp5PqNfh6cl2fMXKS81S7Z3BAoFXFHygEFBeqGdIzU5s NfuJViLwir+8rKM56BX5apvknxQPcQ2TC1pD+5gn5it81bZAwx3qgGY83K9qNsPTh2p5 LlvusRetFQDVacVZGQyhP89diFAbFEuNAbz8ZHT1prx4wehAWBloU1te+ltwCAwvi16s Fr9vm3FT/nle2PaEyIKQRBP6RT5S1IKwXcrRsLEVCC2ynd0NZWygXXmCPt+2QXLd86d4 PW3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=RiCwtpNoox2f+/NHq1/7BxV+rr6wkgqDnJKgrk/kapg=; b=RyQED1DzfDXxaIHvy5QEwtRXmHILzQpGsIuizw5ttdPjTlfaQ+FVPilpSNrKEkNPmg lwi8pJaoesAd5bxD65DsJSCQtfCGapaa0CCuMNrTJWQlGJWVtU3UvLtdVokUBoh6jEJb FyhmW9702cWkH5foOik7pEYXhKJMEvWme2W6J8hEwU8XGopi+29Pkb0ZHbv2akoPpzNi 6yFe0hvMGzm0YXLiACbxo7CZS+GUpB1kkzm+EDrcRiBG8j83zSjsAKyrndvDGYE+DRwR 574qpcmg2u7G5yglW2AjZKV01ErncaTJiaFcEeeYAjFhTSndJhXJDduh4/XSlKSoE6V8 +S4g== X-Gm-Message-State: AOAM533zJNENF+J/4I/225jWOjp+zV9Lx5eeiFNRCUKcCduSwjXnuWnf TWu759Y0dDyZwufXWI8GcLeFoqClv7Nc7HpB X-Google-Smtp-Source: ABdhPJxdc+ne+7nn7IQa1kPbbbAESHjwQNot5B0QNqApUTM6S/VLu+plX17vEF6J9cF2KlnoaL592Q== X-Received: by 2002:a1c:b644:: with SMTP id g65mr11686929wmf.145.1605472771837; Sun, 15 Nov 2020 12:39:31 -0800 (PST) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [2001:8b0:bb71:7140:64::1]) by smtp.gmail.com with ESMTPSA id u81sm19007444wmb.27.2020.11.15.12.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2020 12:39:31 -0800 (PST) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 1011806a; Sun, 15 Nov 2020 20:39:30 +0000 (UTC) To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH 06/27] emacs: fix old bug in notmuch-mua-mail In-Reply-To: <20201108190311.1397-7-jonas@bernoul.li> References: <20201108190311.1397-1-jonas@bernoul.li> <20201108190311.1397-7-jonas@bernoul.li> X-HGTTG: zarquon From: David Edmondson Date: Sun, 15 Nov 2020 20:39:30 +0000 Message-ID: MIME-Version: 1.0 Message-ID-Hash: VEHWY7A5QSX2TX4C4WTJZE45J2CRTNYU X-Message-ID-Hash: VEHWY7A5QSX2TX4C4WTJZE45J2CRTNYU X-MailFrom: dme@dme.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=dme-org.20150623.gappssmtp.com header.s=20150623 header.b=sRds2dfv; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.01 X-TUID: PXnikCGRXvKA On Sunday, 2020-11-08 at 20:02:50 +01, Jonas Bernoulli wrote: > This fixes a regression introduced in [1: 7e20d264]. If the argument > RETURN-ACTION was non-nil then we should pass along the value of that > argument. Instead we passed along the constant symbol `return-action'. > > 1: 7e20d26480553f57d53bd9ec28cae163c1ac91e3 > emacs: Fix mail composition under Emacs 23 Reviewed-by: David Edmondson > --- > emacs/notmuch-mua.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index 616b625c..1204fb6a 100644 > --- a/emacs/notmuch-mua.el > +++ b/emacs/notmuch-mua.el > @@ -402,7 +402,7 @@ (defun notmuch-mua-mail (&optional to subject other-headers continue > ;; argument. Pass it only if it is supplied by the caller. This > ;; will never be the case when we're called by `compose-mail' in > ;; Emacs 23. > - (when return-action (nconc args '(return-action))) > + (when return-action (nconc args (list return-action))) > (apply 'message-setup-1 headers args)) > (notmuch-fcc-header-setup) > (message-sort-headers) > -- > 2.29.1 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org dme. -- This is not how I woke up, but it's how I look now.