unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Edmondson <dme@dme.org>
To: yoctocell <public@yoctocell.xyz>, notmuch@notmuchmail.org
Subject: Re: emacs-notmuch: notmuch-show-hook runs too early
Date: Fri, 08 Jan 2021 20:41:12 +0000	[thread overview]
Message-ID: <cunh7nrp3fb.fsf@dme.org> (raw)
In-Reply-To: <875z4bvkjj.fsf@yoctocell.xyz>

On Tuesday, 2021-01-05 at 09:45:52 +01, yoctocell wrote:

> I am using a package called gnus-article-treat-patch[0] which colorizes
> patches in emails. It works expected when I manually call
> `ft/gnus-article-treat-patch' in a notmuch-show buffer, but it doesn't
> work when I add it as a hook.

Is there a reason not to use notmuch-wash-convert-inline-patch-to-part?

It doesn't do quite as much (nothing for the header), but the patch
should be appropriately rendered.

> (add-hook 'notmuch-show-hook 'ft/gnus-article-treat-patch)
>
> `notmuch-show-hook' seems to be called too early so
> `ft/gnus-article-treat-patch' isn't able to read the contents of the
> message and apply any highlighting.
>
> I managed to get it to work with the following patch.
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 056c4e30..f9f3bdb1 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1317,11 +1317,11 @@ If no messages match the query return NIL."
> 				      (notmuch-sanitize
> 				       (notmuch-show-strip-re
> 					(notmuch-show-get-subject)))))
> -      (run-hooks 'notmuch-show-hook)
>        (if state
> 	  (notmuch-show-apply-state state)
> 	;; With no state to apply, just go to the first message.
> -	(notmuch-show-goto-first-wanted-message)))
> +	(notmuch-show-goto-first-wanted-message))
> +      (run-hooks 'notmuch-show-hook))
>      ;; Report back to the caller whether any messages matched.
>      forest))
>
> [0]: https://github.com/velkyel/gnus-article-treat-patch
>
> -- 
> yoctocell
> 8B88 2502 31D7 03B1 68BC  2691 3851 020D 7E61 BBC2
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

dme.
-- 
He caught a fleeting glimpse of a man, moving uphill pursued by a bus.

  parent reply	other threads:[~2021-01-08 20:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  8:45 emacs-notmuch: notmuch-show-hook runs too early yoctocell
2021-01-08 20:23 ` David Bremner
2021-01-08 20:38   ` yoctocell
2021-01-08 20:41 ` David Edmondson [this message]
2021-01-08 20:58   ` yoctocell
  -- strict thread matches above, loose matches on Subject: below --
2020-12-29 14:59 yoctocell
2020-12-29 15:03 ` yoctocell
2020-12-29 14:58 yoctocell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cunh7nrp3fb.fsf@dme.org \
    --to=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).