From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4F702431FAF for ; Wed, 18 Jan 2012 23:39:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X9iThESRK-WI for ; Wed, 18 Jan 2012 23:39:40 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A0E00431FAE for ; Wed, 18 Jan 2012 23:39:40 -0800 (PST) Received: by werp13 with SMTP id p13so2257211wer.26 for ; Wed, 18 Jan 2012 23:39:39 -0800 (PST) Received: by 10.216.45.199 with SMTP id p49mr9361544web.42.1326958779251; Wed, 18 Jan 2012 23:39:39 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id u12sm1691321wiv.10.2012.01.18.23.39.37 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Jan 2012 23:39:38 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id F2E239FE61; Thu, 19 Jan 2012 07:39:35 +0000 (GMT) To: Dmitry Kurochkin Subject: Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks. In-Reply-To: <874nvs96ps.fsf@gmail.com> References: <1326907993-11054-1-git-send-email-dme@dme.org> <1326908371-11949-1-git-send-email-dme@dme.org> <877h0o99aj.fsf@gmail.com> <874nvs96ps.fsf@gmail.com> User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 19 Jan 2012 07:39:32 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Cc: notmuch X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jan 2012 07:39:41 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 18 Jan 2012 23:00:15 +0400, Dmitry Kurochkin wrote: > > That would allow a sane default (("image/*" "text/*") perhaps), but also > > allow more to be added to that list (or some to be removed), either by > > code that detected the (in)ability to render it or the user. >=20 > Perhaps there is such a list in mm already? There's a function which does almost exactly this - `mm-inlinable-p'. It has a list of types and tests, `mm-inline-media-tests'. Some of those tests require access to the part content to decide if the part is inlinable. Many of them don't. The image/jpeg test _does_ want access to the part content. We're already using this function, of course. `mm-inlined-p' is the corresponding "does the user want this part inlined" test. It's much simpler and never looks at the part content. Currently we merge those tests into one: (if (and (mm-inlinable-p handle) (mm-inlined-p handle)) and have acquired part content either before or after the combined test. Perhaps we could test `mm-inlined-p' first, then insert the content, then test `mm-inlinable-p'? That way we would not acquire the content for parts for which the user (or code) has selected not to inline the content. Currently `mm-inlined-p' suggests that the following should be inlined by default: "image/.*" "text/.*" "message/delivery-status" "message/rfc822" "message/partial" "message/external-body" "application/emacs-lisp" "application/x-emacs-lisp" "application/pgp-signature" "application/x-pkcs7-signature" "application/pkcs7-signature" "application/x-pkcs7-mime" "application/pkcs7-mime" These are the only types for which we'd acquire the part content for examination by `mm-inlinable-p' (by default). --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8XyLQACgkQaezQq/BJZRZ+fwCfViecAHmqysxKht+mkXJwMQbW htcAniAMF20oMd+IItd9aq2iiXqFHQRo =fif9 -----END PGP SIGNATURE----- --=-=-=--