From: David Edmondson <dme@dme.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known.
Date: Thu, 12 Jan 2012 12:00:14 +0000 [thread overview]
Message-ID: <cun8vldm8q9.fsf@hotblack-desiato.hh.sledj.net> (raw)
In-Reply-To: <87k44ym6ka.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]
On Wed, 11 Jan 2012 22:34:45 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> -1
Which puts me back to 0 :-(
> One particular issue with your patch is that it adds (incorrect) charset
> parameter to plain/text parts which are converted to UTF-8 in JSON
> output.
Patches that break things should obviously not be accepted...
> I already tried to solve the above problem using a more general approach
> (output all content-type parameters, not just charset) [1]. There was a
> lengthy discussion on IRC about it and it was rejected. The consensus
> was that we need to make some more substantial changes to JSON and raw
> output formats to properly fix the issue (and the issue is more general
> than what this patch fixes, other content-type parameters are useful for
> renderers as well and should be included in the output).
...but a useful point fix should not be blocked by theoretical future
work.
> I am planning to work on a proper fix for this issue, but decided to
> postpone it until Austin's rewrite of notmuch show is complete.
If the UTF8 text/plain part issue can be resolved, would you be happier
to accept this as an interim fix whilst we wait for the more complete
solution?
Nothing in the patch (so far) should make your proposed changes any
harder, so I'm not sure what the problem would be.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2012-01-12 12:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 10:50 [PATCH] notmuch/emacs: Observe the charset of encoded parts, where known David Edmondson
2012-01-11 11:03 ` Tomi Ollila
2012-01-11 18:34 ` Dmitry Kurochkin
2012-01-12 12:00 ` David Edmondson [this message]
2012-01-12 14:17 ` Dmitry Kurochkin
2012-01-12 14:42 ` David Edmondson
2012-01-12 14:53 ` Dmitry Kurochkin
2012-01-12 13:31 ` [PATCH v2] notmuch/emacs: Observe the charset of text/html " David Edmondson
2012-01-12 18:49 ` Austin Clements
2012-01-12 19:14 ` David Edmondson
2012-01-13 9:44 ` [PATCH v3] " David Edmondson
2012-01-13 10:09 ` Tomi Ollila
2012-01-13 23:09 ` Austin Clements
2012-01-14 1:49 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cun8vldm8q9.fsf@hotblack-desiato.hh.sledj.net \
--to=dme@dme.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).