From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 347E7431E64 for ; Mon, 30 Jan 2012 01:37:22 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ksgvtrKO9+7U for ; Mon, 30 Jan 2012 01:37:21 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 82426431FBC for ; Mon, 30 Jan 2012 01:37:21 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so3768569wgb.2 for ; Mon, 30 Jan 2012 01:37:20 -0800 (PST) Received: by 10.180.89.71 with SMTP id bm7mr21879002wib.20.1327916240206; Mon, 30 Jan 2012 01:37:20 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id bj10sm28851646wib.9.2012.01.30.01.37.18 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 30 Jan 2012 01:37:19 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 4B04CA05FB; Mon, 30 Jan 2012 09:37:17 +0000 (GMT) To: Jameson Graef Rollins , notmuch@notmuchmail.org Subject: Re: [PATCH 0/3] reworked crypto toggle, plus a couple of other toggles In-Reply-To: <87ehuiz31a.fsf@servo.finestructure.net> References: <1327486729-18052-1-git-send-email-dme@dme.org> <87ehuiz31a.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 30 Jan 2012 09:37:17 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2012 09:37:22 -0000 --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 29 Jan 2012 12:06:57 -0800, Jameson Graef Rollins wrote: > > My inclination is to remove `notmuch-crypto-process-mime' altogether > > (declared it an obsolete variable) and allow users to set a default > > for `notmuch-show-process-crypto' directly, but that is not done in > > this patchset while awaiting feedback. >=20 > I'm not sure I understand this. `notmuch-show-process-crypto' *is* what > sets the default for the `notmuch-show-process-crypto' buffer-local > variable. How would you change the current behavior or settings (beyond > just a variable rename)? The problem with the code as I posted can be seen if you imagine the following ~/.emacs.el sequence: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline Content-Transfer-Encoding: quoted-printable (require 'notmuch) ;; Ends up loading notmuch-crypto.el and notmuch-show.el. ;; notmuch-crypto.el has `notmuch-crypto-process-mime' default as `nil'. ;; notmuch-show.el uses the value of `notmuch-crypto-process-mime' to ;; set the default value of `notmuch-show-process-crypto', so it is now ;; also `nil'. (custom-set-variables '(notmuch-crypto-process-mime t)) ;; `notmuch-crypto-process-mime' is now `t', but ;; `notmuch-show-process-crypto' remains `nil'. ;; No crypto decoding takes place in `notmuch-show-mode'. --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable I'm sure that I can figure out either some `defcustom' goop or worse to sort it out so that the initialisation happens correctly. > > `notmuch-crypto-process-mime' is used only in notmuch-show.el, so the > > setting really belongs there with an appropriate name. >=20 > I intentionally put this in a separate section in case there were > eventually other needs for this setting beyond just show mode. I > personally think we should just leave it where it is, particularly > since it's been there for a while. Okay. --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEUEARECAAYFAk8mZM0ACgkQaezQq/BJZRZhngCeKymY9EQoNYYWhJGqUWsfD+ep IdEAl09OD4hB2AfjX7HXuQH8YoQuNAE= =C2+K -----END PGP SIGNATURE----- --==-=-=--