From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 74687431FD0 for ; Thu, 22 Dec 2011 07:27:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 45kotstnL3KF for ; Thu, 22 Dec 2011 07:27:31 -0800 (PST) Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 50A5C431FB6 for ; Thu, 22 Dec 2011 07:27:31 -0800 (PST) Received: by werm12 with SMTP id m12so4233076wer.26 for ; Thu, 22 Dec 2011 07:27:30 -0800 (PST) Received: by 10.216.134.232 with SMTP id s82mr11748817wei.19.1324567649937; Thu, 22 Dec 2011 07:27:29 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id fy5sm23384250wib.7.2011.12.22.07.27.28 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Dec 2011 07:27:28 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id E6E479FBB6; Thu, 22 Dec 2011 15:27:26 +0000 (GMT) To: Aaron Ecay , notmuch@notmuchmail.org Subject: Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode. In-Reply-To: References: <1324553312-10972-1-git-send-email-dme@dme.org> <1324556204-15700-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Thu, 22 Dec 2011 15:27:22 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 15:27:35 -0000 --=-=-= Content-Type: text/plain On Thu, 22 Dec 2011 09:29:55 -0500, Aaron Ecay wrote: > Would the problem you had with previous-s-c-prop-change be fixed by the > patch to the original function I sent in the thread starting at > id:"m2y5u5cykp.fsf@kcals.intra.maillard.im" ? I think so, yes. Re-writing the new version I posted to use `previous-single-char-property-value' in the way that you describe: ((let ((visible-bottom (notmuch-show-message-bottom))) (while (invisible-p visible-bottom) (setq visible-bottom (max (point-min) (1- (previous-single-char-property-change visible-bottom 'invisible))))) (> visible-bottom (window-end))) ;; The end of this message is not visible - scroll. (scroll-up) nil) seems to work in quick testing. I'd vote to integrate your change if it seems correct to everyone else, then I'll argue for a re-write separately. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk7zTFsACgkQaezQq/BJZRZ2wwCeI877t4HEkME2lHH04V0qjzxJ W/8An0uNJsW6qD4VXV5qqS7Xd6svBwo9 =I28a -----END PGP SIGNATURE----- --=-=-=--