From: David Edmondson <dme@dme.org>
To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.
Date: Thu, 22 Dec 2011 15:27:22 +0000 [thread overview]
Message-ID: <cun4nwswrs5.fsf@hotblack-desiato.hh.sledj.net> (raw)
In-Reply-To: <m2wr9ollwc.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, 22 Dec 2011 09:29:55 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
> Would the problem you had with previous-s-c-prop-change be fixed by the
> patch to the original function I sent in the thread starting at
> id:"m2y5u5cykp.fsf@kcals.intra.maillard.im" ?
I think so, yes. Re-writing the new version I posted to use
`previous-single-char-property-value' in the way that you describe:
((let ((visible-bottom (notmuch-show-message-bottom)))
(while (invisible-p visible-bottom)
(setq visible-bottom (max (point-min)
(1- (previous-single-char-property-change
visible-bottom 'invisible)))))
(> visible-bottom (window-end)))
;; The end of this message is not visible - scroll.
(scroll-up)
nil)
seems to work in quick testing.
I'd vote to integrate your change if it seems correct to everyone else,
then I'll argue for a re-write separately.
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-12-22 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 11:28 [RFC][PATCH] emacs: Re-implement advance/rewind functions of notmuch-show-mode David Edmondson
2011-12-22 12:16 ` [RFC][PATCH v2] " David Edmondson
2011-12-22 12:38 ` [RFC][PATCH v3] " David Edmondson
2011-12-22 14:29 ` [RFC][PATCH v2] " Aaron Ecay
2011-12-22 15:27 ` David Edmondson [this message]
2011-12-22 22:41 ` Xavier Maillard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cun4nwswrs5.fsf@hotblack-desiato.hh.sledj.net \
--to=dme@dme.org \
--cc=aaronecay@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).