From: David Edmondson <dme@dme.org>
To: Daniel Schoepe <daniel@schoepe.org>,
James Vasile <james@hackervisions.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] Calls to notmuch get queued and executed asynchronously.
Date: Fri, 30 Dec 2011 10:52:17 +0000 [thread overview]
Message-ID: <cun4nwi8h7i.fsf@hotblack-desiato.hh.sledj.net> (raw)
In-Reply-To: <87wrbykr13.fsf@gilead.invalid>
[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]
On Fri, 21 Oct 2011 22:50:48 +0200, Daniel Schoepe <daniel@schoepe.org> wrote:
> On Tue, 23 Feb 2010 11:32:51 -0500, James Vasile <james@hackervisions.org> wrote:
> > Added notmuch-enqueue-asynch to replace calls to
> > notmuch-call-notmuch-process. Calls to notmuch are then queued and
> > executed asynchronously. If the db is busy and we get an error saying
> > it was locked, keep trying until the db is no longer busy. Errors go
> > in a buffer as per usual.
>
> I discovered this patch a while ago and it almost applies cleanly (the
> conflicts are easy to fix though) and it has made the emacs UI for
> notmuch _much_ more responsive and enjoyable for me. As discussed on
> IRC, issues such as where to handle retries in case the database is
> locked should probably be handled in the notmuch binary instead of each
> UI.
>
> I am however unaware of any patches to accomplish that and with the pace
> of development / patch reviews the way it is at the moment, this patch
> is a really helpful stop-gap (performing calls to notmuch asynchronously
> is useful independently of where concurrency issues are handled though)
> for me. If someone else agrees, I can fix the conflicts for this patch
> and send the revised version to the list.
It would be good to have an updated version of this patch if it is still
considered useful, though I don't suffer particularly from lag in the
emacs UI.
One concern is the string searching on the output of 'notmuch' to detect
the database locked condition. Perhaps 'notmuch' could be made to
return a specific error code in that case, negating the need to string
match?
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-12-30 10:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 16:32 [PATCH] Calls to notmuch get queued and executed asynchronously James Vasile
2010-02-24 19:28 ` James Vasile
2011-10-21 20:50 ` Daniel Schoepe
2011-12-30 10:52 ` David Edmondson [this message]
2011-12-30 19:21 ` Aaron Ecay
2012-01-03 10:58 ` David Edmondson
2012-10-12 2:21 ` Ethan Glasser-Camp
2012-10-12 16:58 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cun4nwi8h7i.fsf@hotblack-desiato.hh.sledj.net \
--to=dme@dme.org \
--cc=daniel@schoepe.org \
--cc=james@hackervisions.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).