From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C116B6DE01F8 for ; Mon, 8 Oct 2018 05:14:36 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.384 X-Spam-Level: X-Spam-Status: No, score=0.384 tagged_above=-999 required=5 tests=[AWL=-0.269, DKIMWL_WL_MED=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ApxaVH__obpC for ; Mon, 8 Oct 2018 05:14:34 -0700 (PDT) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by arlo.cworth.org (Postfix) with ESMTPS id 945996DE0122 for ; Mon, 8 Oct 2018 05:14:34 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id a8-v6so8037816wmf.1 for ; Mon, 08 Oct 2018 05:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=1+qhT3dMtrk1ez3/hqmofMGlyoVZDtNwudsQ72QxGPg=; b=hwaqxHYPARm3wie3FXWl0Lm4FdXCcTUBbyivBnCFm8GXqB1836dx4a/XQRgliq2VLt 3Jzcr46jixzq3jXGlZLZsgeO6EJaYlP+1y49Lvfnh9qi/WH8ibV9egHesbAX6WNviQzH wQyYnROeALpNNvw1a71m7BI5zM3CtYnnnw8wcCEIw3rMmNrFPiaISCGstX/qHeUdTc2m PbbaF4pmp2se1JL6rJUpe1egiVJwAqcFbVcj11y4mMCgBfIQmICq9FUZUcCj7A4wEK89 GMkZZ9rwoiAQuYcj1kGl0NrV7/LKe6Uav1EiBPdOLXwmw7blzcMBhHYnvc6usv0mAoT0 w4wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=1+qhT3dMtrk1ez3/hqmofMGlyoVZDtNwudsQ72QxGPg=; b=ltYoBV5314O/o8e/P3vQzlpmoYGs6zeBmNUspU3LHF/yDbMa3Rgm0ethVkbwVNVB5L TME3qb17aATIhmuLrxgZ85yUMzzeKKkImL3weS6jjAZ0NC9jdL9mIEzsFRt2zzpJ3aHl 7XcxkBDlqROE0icBuZACsPanPAJm4feuYtdRkmFKQg6vXnoZv3rSeog89Cd1y/0I1Ca7 AfbE2v7wjOVceFp9OQDmN0mk+af0gPCTeJJHVXZRP2qLEo/36ClPsn7JUkTelao7xST+ G0PBN5Eg14F+pCOf4sXnSLID7RB3IoC+wBZshzvvf+wuEDzmrypw4J0Xgr1HdH277qOt /LlQ== X-Gm-Message-State: ABuFfoifcOdih/BTYQ+g6oZ7yXaSnTGmkFWuyA+cS8rJAk/INd2RoMqG pna3ijHe/HPOoud4U2wBAwyivkJwRbw= X-Google-Smtp-Source: ACcGV63PeB70rM13GIhA2FJrB9olI2G86+3X3Yzx2CMmvE0jE8IQPkzEmrDeP5HEwU9UZ12lgEwYJg== X-Received: by 2002:a1c:a851:: with SMTP id r78-v6mr14926781wme.97.1539000872201; Mon, 08 Oct 2018 05:14:32 -0700 (PDT) Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id 90-v6sm20969676wrg.86.2018.10.08.05.14.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Oct 2018 05:14:30 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id ed4f7ee4; Mon, 8 Oct 2018 12:14:29 +0000 (UTC) To: William Casarin , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: filter tag completions by current query In-Reply-To: <20181008114752.14457-1-jb55@jb55.com> References: <20181008114752.14457-1-jb55@jb55.com> X-HGTTG: gag-halfrunt From: David Edmondson Date: Mon, 08 Oct 2018 13:14:29 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 12:14:36 -0000 Looks good - a nice usability improvement. On Monday, 2018-10-08 at 04:47:52 -07, William Casarin wrote: > When filtering by tags in notmuch-search-filter-by-tag, only return tags > related to the current query. > > Before, it was returning all tags. There's no reason to refine the > current query with tags that don't exist in the current result set. > > Signed-off-by: William Casarin > --- > emacs/notmuch.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index 44402f8a..28c50425 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -1076,7 +1076,7 @@ current search results AND the additional query string provided." > Runs a new search matching only messages that match both the > current search results AND that are tagged with the given tag." > (interactive > - (list (notmuch-select-tag-with-completion "Filter by tag: "))) > + (list (notmuch-select-tag-with-completion "Filter by tag: " notmuch-search-query-string))) > (notmuch-search (concat notmuch-search-query-string " and tag:" tag) notmuch-search-oldest-first)) > > ;;;###autoload > -- > 2.19.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch dme. -- Oh there ain't no way to say I love you more.