From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v3 00/15] reply refactor, fixes
Date: Tue, 13 Sep 2016 20:14:07 +0300 [thread overview]
Message-ID: <cover.1473786451.git.jani@nikula.org> (raw)
Updated version of [1] to address David's review comments, mostly just
commit message updates. Also incorporates the multiple corpora support
from [2], with the commit message extended a bit, and rebasing patch 2
on top of it.
BR,
Jani.
[1] id:cover.1471088022.git.jani@nikula.org
[2] id:1473609824-6258-1-git-send-email-jani@nikula.org
Jani Nikula (15):
test: make it possible to have multiple corpora
test: add known broken test for reply to message with multiple Cc
headers
cli/reply: push notmuch reply format abstraction lower in the stack
cli/reply: reuse show_reply_headers() in headers-only format
cli/reply: unify reply format functions
cli/reply: reorganize create_reply_message()
cli/reply: make references header creation easier to follow
cli/reply: reuse create_reply_message() also for headers-only format
cli/reply: reduce the reply format abstractions
cli/reply: use dedicated functions for reply to mapping
cli/reply: check for NULL list first in scan_address_list()
cli/reply: return internet address list from get header funcs
cli/reply: do not parse Reply-To: header into internet address list
twice
cli/reply: pass gmime message to Reply-To: redundancy detection
cli/reply: only pass gmime message to add recipients to reply message
notmuch-reply.c | 435 ++++++++-------------
test/T220-reply.sh | 12 +
test/corpora/README | 11 +
test/corpora/broken/broken-cc | 9 +
test/{corpus => corpora/default}/01:2, | 0
test/{corpus => corpora/default}/02:2, | 0
test/{corpus => corpora/default}/bar/17:2, | 0
test/{corpus => corpora/default}/bar/18:2, | 0
test/{corpus => corpora/default}/bar/baz/05:2, | 0
test/{corpus => corpora/default}/bar/baz/23:2, | 0
test/{corpus => corpora/default}/bar/baz/24:2, | 0
test/{corpus => corpora/default}/bar/baz/cur/25:2, | 0
test/{corpus => corpora/default}/bar/baz/cur/26:2, | 0
test/{corpus => corpora/default}/bar/baz/new/27:2, | 0
test/{corpus => corpora/default}/bar/baz/new/28:2, | 0
test/{corpus => corpora/default}/bar/cur/19:2, | 0
test/{corpus => corpora/default}/bar/cur/20:2, | 0
test/{corpus => corpora/default}/bar/new/21:2, | 0
test/{corpus => corpora/default}/bar/new/22:2, | 0
test/{corpus => corpora/default}/cur/29:2, | 0
test/{corpus => corpora/default}/cur/30:2, | 0
test/{corpus => corpora/default}/cur/31:2, | 0
test/{corpus => corpora/default}/cur/32:2, | 0
test/{corpus => corpora/default}/cur/33:2, | 0
test/{corpus => corpora/default}/cur/34:2, | 0
test/{corpus => corpora/default}/cur/35:2, | 0
test/{corpus => corpora/default}/cur/36:2, | 0
test/{corpus => corpora/default}/cur/37:2, | 0
test/{corpus => corpora/default}/cur/38:2, | 0
test/{corpus => corpora/default}/cur/39:2, | 0
test/{corpus => corpora/default}/cur/40:2, | 0
test/{corpus => corpora/default}/cur/41:2, | 0
test/{corpus => corpora/default}/cur/42:2, | 0
test/{corpus => corpora/default}/cur/43:2, | 0
test/{corpus => corpora/default}/cur/44:2, | 0
test/{corpus => corpora/default}/cur/45:2, | 0
test/{corpus => corpora/default}/cur/46:2, | 0
test/{corpus => corpora/default}/cur/47:2, | 0
test/{corpus => corpora/default}/cur/48:2, | 0
test/{corpus => corpora/default}/cur/49:2, | 0
test/{corpus => corpora/default}/cur/50:2, | 0
test/{corpus => corpora/default}/cur/51:2, | 0
test/{corpus => corpora/default}/cur/52:2, | 0
test/{corpus => corpora/default}/cur/53:2, | 0
test/{corpus => corpora/default}/foo/06:2, | 0
test/{corpus => corpora/default}/foo/baz/11:2, | 0
test/{corpus => corpora/default}/foo/baz/12:2, | 0
test/{corpus => corpora/default}/foo/baz/cur/13:2, | 0
test/{corpus => corpora/default}/foo/baz/cur/14:2, | 0
test/{corpus => corpora/default}/foo/baz/new/15:2, | 0
test/{corpus => corpora/default}/foo/baz/new/16:2, | 0
test/{corpus => corpora/default}/foo/cur/07:2, | 0
test/{corpus => corpora/default}/foo/cur/08:2, | 0
test/{corpus => corpora/default}/foo/new/03:2, | 0
test/{corpus => corpora/default}/foo/new/09:2, | 0
test/{corpus => corpora/default}/foo/new/10:2, | 0
test/{corpus => corpora/default}/new/04:2, | 0
test/test-lib.sh | 19 +-
58 files changed, 212 insertions(+), 274 deletions(-)
create mode 100644 test/corpora/README
create mode 100644 test/corpora/broken/broken-cc
rename test/{corpus => corpora/default}/01:2, (100%)
rename test/{corpus => corpora/default}/02:2, (100%)
rename test/{corpus => corpora/default}/bar/17:2, (100%)
rename test/{corpus => corpora/default}/bar/18:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/05:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/23:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/24:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/cur/25:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/cur/26:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/new/27:2, (100%)
rename test/{corpus => corpora/default}/bar/baz/new/28:2, (100%)
rename test/{corpus => corpora/default}/bar/cur/19:2, (100%)
rename test/{corpus => corpora/default}/bar/cur/20:2, (100%)
rename test/{corpus => corpora/default}/bar/new/21:2, (100%)
rename test/{corpus => corpora/default}/bar/new/22:2, (100%)
rename test/{corpus => corpora/default}/cur/29:2, (100%)
rename test/{corpus => corpora/default}/cur/30:2, (100%)
rename test/{corpus => corpora/default}/cur/31:2, (100%)
rename test/{corpus => corpora/default}/cur/32:2, (100%)
rename test/{corpus => corpora/default}/cur/33:2, (100%)
rename test/{corpus => corpora/default}/cur/34:2, (100%)
rename test/{corpus => corpora/default}/cur/35:2, (100%)
rename test/{corpus => corpora/default}/cur/36:2, (100%)
rename test/{corpus => corpora/default}/cur/37:2, (100%)
rename test/{corpus => corpora/default}/cur/38:2, (100%)
rename test/{corpus => corpora/default}/cur/39:2, (100%)
rename test/{corpus => corpora/default}/cur/40:2, (100%)
rename test/{corpus => corpora/default}/cur/41:2, (100%)
rename test/{corpus => corpora/default}/cur/42:2, (100%)
rename test/{corpus => corpora/default}/cur/43:2, (100%)
rename test/{corpus => corpora/default}/cur/44:2, (100%)
rename test/{corpus => corpora/default}/cur/45:2, (100%)
rename test/{corpus => corpora/default}/cur/46:2, (100%)
rename test/{corpus => corpora/default}/cur/47:2, (100%)
rename test/{corpus => corpora/default}/cur/48:2, (100%)
rename test/{corpus => corpora/default}/cur/49:2, (100%)
rename test/{corpus => corpora/default}/cur/50:2, (100%)
rename test/{corpus => corpora/default}/cur/51:2, (100%)
rename test/{corpus => corpora/default}/cur/52:2, (100%)
rename test/{corpus => corpora/default}/cur/53:2, (100%)
rename test/{corpus => corpora/default}/foo/06:2, (100%)
rename test/{corpus => corpora/default}/foo/baz/11:2, (100%)
rename test/{corpus => corpora/default}/foo/baz/12:2, (100%)
rename test/{corpus => corpora/default}/foo/baz/cur/13:2, (100%)
rename test/{corpus => corpora/default}/foo/baz/cur/14:2, (100%)
rename test/{corpus => corpora/default}/foo/baz/new/15:2, (100%)
rename test/{corpus => corpora/default}/foo/baz/new/16:2, (100%)
rename test/{corpus => corpora/default}/foo/cur/07:2, (100%)
rename test/{corpus => corpora/default}/foo/cur/08:2, (100%)
rename test/{corpus => corpora/default}/foo/new/03:2, (100%)
rename test/{corpus => corpora/default}/foo/new/09:2, (100%)
rename test/{corpus => corpora/default}/foo/new/10:2, (100%)
rename test/{corpus => corpora/default}/new/04:2, (100%)
--
2.1.4
next reply other threads:[~2016-09-13 17:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 17:14 Jani Nikula [this message]
2016-09-13 17:14 ` [PATCH v3 01/15] test: make it possible to have multiple corpora Jani Nikula
2016-09-13 17:14 ` [PATCH v3 02/15] test: add known broken test for reply to message with multiple Cc headers Jani Nikula
2016-09-13 17:14 ` [PATCH v3 03/15] cli/reply: push notmuch reply format abstraction lower in the stack Jani Nikula
2016-09-13 17:14 ` [PATCH v3 04/15] cli/reply: reuse show_reply_headers() in headers-only format Jani Nikula
2016-09-13 17:14 ` [PATCH v3 05/15] cli/reply: unify reply format functions Jani Nikula
2016-09-13 17:14 ` [PATCH v3 06/15] cli/reply: reorganize create_reply_message() Jani Nikula
2016-09-13 17:14 ` [PATCH v3 07/15] cli/reply: make references header creation easier to follow Jani Nikula
2016-09-13 17:14 ` [PATCH v3 08/15] cli/reply: reuse create_reply_message() also for headers-only format Jani Nikula
2016-09-13 17:14 ` [PATCH v3 09/15] cli/reply: reduce the reply format abstractions Jani Nikula
2016-09-13 17:14 ` [PATCH v3 10/15] cli/reply: use dedicated functions for reply to mapping Jani Nikula
2016-09-13 17:14 ` [PATCH v3 11/15] cli/reply: check for NULL list first in scan_address_list() Jani Nikula
2016-09-13 17:14 ` [PATCH v3 12/15] cli/reply: return internet address list from get header funcs Jani Nikula
2016-09-13 17:14 ` [PATCH v3 13/15] cli/reply: do not parse Reply-To: header into internet address list twice Jani Nikula
2016-09-13 17:14 ` [PATCH v3 14/15] cli/reply: pass gmime message to Reply-To: redundancy detection Jani Nikula
2016-09-13 17:14 ` [PATCH v3 15/15] cli/reply: only pass gmime message to add recipients to reply message Jani Nikula
2016-09-13 19:03 ` [PATCH v3 00/15] reply refactor, fixes Tomi Ollila
2016-09-17 12:25 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1473786451.git.jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).