unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: michaeljgruber+grubix+git@gmail.com
To: notmuch@notmuchmail.org
Cc: Michael J Gruber <git@grubix.eu>
Subject: [PATCH] Replace `without-restriction` with `save-restriction`
Date: Mon, 17 Jun 2024 16:04:01 +0200	[thread overview]
Message-ID: <b33900237b28f5a8b943ca9048536d2cde19151b.1718631755.git.git@grubix.eu> (raw)
In-Reply-To: <87wmmn3imf.fsf@marcfargas.com>

From: Michael J Gruber <git@grubix.eu>

37c022ae ("Use `without-restriction` in `with-temporary-notmuch-message-buffer`", 2024-03-14)
introduced a fix for draft saving in a way which is supported on Emacs
29 and above only. Replace this with a construct which we have used
before, so that we keep the same compatibility level.
---
So, this fixes one incompatibility, and as per the emacs docs, those
should be equivalent.

Alas: T630-emacs-draft introduced another incompatibility by using
`delete-line`, it seems. I haven't checked versions nor substitutes
yet.

 emacs/notmuch-maildir-fcc.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index cf50e855..c7b403cf 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -145,7 +145,8 @@ Otherwise set it according to `notmuch-fcc-dirs'."
 
 (defmacro with-temporary-notmuch-message-buffer (&rest body)
   "Set-up a temporary copy of the current message-mode buffer."
-  `(without-restriction
+  `(save-restriction
+     (widen)
      (let ((case-fold-search t)
 	   (buf (current-buffer))
 	   (mml-externalize-attachments message-fcc-externalize-attachments))
-- 
2.45.2.749.g54362de8d7

  reply	other threads:[~2024-06-17 14:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 16:32 notmuch.el, needs without-restriction to properly save draft Marc Fargas
2024-03-13 23:00 ` Carl Worth
2024-03-14 15:03   ` [PATCH] Use `without-restriction` in `with-temporary-notmuch-message-buffer` Marc Fargas
2024-03-15  8:33     ` Marc Fargas
2024-03-15  9:59       ` David Bremner
2024-03-24 17:04   ` notmuch.el, needs without-restriction to properly save draft Marc Fargas
2024-03-24 17:54     ` Marc Fargas
2024-04-04 11:13       ` Marc Fargas
2024-06-15 17:57       ` David Bremner
2024-06-17  9:27         ` Michael J Gruber
2024-06-17  9:53           ` Marc Fargas
2024-06-17 10:27             ` David Bremner
2024-06-17 10:29               ` David Bremner
2024-06-17 11:37             ` Marc Fargas
2024-06-17 14:04               ` michaeljgruber+grubix+git [this message]
2024-06-17 19:28                 ` [PATCH v2 1/2] Replace `without-restriction` with `save-restriction` michaeljgruber+grubix+git
2024-06-17 19:28                 ` [PATCH v2 2/2] Replace `delete-line` with its definition michaeljgruber+grubix+git
2024-06-17 22:49                   ` David Bremner
2024-06-18  5:58                     ` Marc Fargas
2024-06-18 14:33                       ` Michael J Gruber
2024-06-19 10:48                   ` David Bremner
2024-06-17 14:28               ` notmuch.el, needs without-restriction to properly save draft David Bremner
2024-03-24 17:08   ` Marc Fargas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b33900237b28f5a8b943ca9048536d2cde19151b.1718631755.git.git@grubix.eu \
    --to=michaeljgruber+grubix+git@gmail.com \
    --cc=git@grubix.eu \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).