Please Update Current GLib Requirements For notmuch: - (glib-2.0 >= 2.14) + (glib-2.0 >= 2.22)

Please Update Current GLib Requirements For notmuch: - (glib-2.0 >= 2.14) + (glib-2.0 >= 2.22)

[datapipe]

I've just tried to compile notmuch, after having downloaded it a few
hours back, via: `git clone git://notmuchmail.org/git/notmuch`.
Unfortunately, even though I seem to have all needed dependencies in
place, during the build I ran into the following error:
lib/query.cc: In function 'int
_notmuch_threads_destructor(notmuch_threads_t*)':
lib/query.cc:311: error: 'g_array_unref' was not declared in this scope

Looking into this 'g_array_unref' function, I found that it should be
provided by glib, but it seems that it isn't even defined in any of the
header files installed by glib on this system (v2.20.3), although I did
find it within /usr/include/glib-2.0/glib/garray.h on a system with a
newer version (v2.24.2).  Looking into its documentation, I found the
following:
http://developer.gnome.org/glib/2.31/glib-Arrays.html#g-array-unref
And specifically note:
"g_array_ref ()
...
Since 2.22"

Now, unless I'm misinterpreting this, it seems to me that the
documentation is stating that the function has only been available since
glib v2.22...


--
Sub


---------------------------------------------------------------
DO NOT REPLY TO THIS MESSAGE, THIS ADDRESS IS NOT MONITORED

[PATCH] configure: update explicit check for glib : >= 2.22

[Pieter Praet]

As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc',
which was only introduced in glib 2.22, so update the dependency.

Thanks to datapipe@gmail.com for reporting this [1].

Also see commit b88e6abc.

[1] id:"alpine.DEB.2.02.1201132130220.21970@ltspubuntu4.int.smq.datapipe.net"
---
 configure |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/configure b/configure
index e90b76f..8b85b9d 100755
--- a/configure
+++ b/configure
@@ -289,10 +289,10 @@ if [ "$have_gmime" = "0" ]; then
 fi
 
 # GMime already depends on Glib >= 2.12, but we use at least one Glib
-# function that only exists as of 2.14, (g_hash_table_get_keys)
-printf "Checking for Glib development files (>= 2.14)... "
+# function that only exists as of 2.22, (g_array_unref)
+printf "Checking for Glib development files (>= 2.22)... "
 have_glib=0
-if pkg-config --exists 'glib-2.0 >= 2.14'; then
+if pkg-config --exists 'glib-2.0 >= 2.22'; then
     printf "Yes.\n"
     have_glib=1
     glib_cflags=$(pkg-config --cflags glib-2.0)
@@ -416,7 +416,7 @@ EOF
 	echo "	http://spruce.sourceforge.net/gmime/"
     fi
     if [ $have_glib -eq 0 ]; then
-	echo "	Glib library >= 2.14 (including development files such as headers)"
+	echo "	Glib library >= 2.22 (including development files such as headers)"
 	echo "	http://ftp.gnome.org/pub/gnome/sources/glib/"
     fi
     if [ $have_talloc -eq 0 ]; then
-- 
1.7.8.1

Re: [PATCH] configure: update explicit check for glib : >= 2.22

[Tomi Ollila]

On Fri,  3 Feb 2012 13:12:25 +0100, Pieter Praet <pieter@praet.org> wrote:
> As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc',
> which was only introduced in glib 2.22, so update the dependency.
> 
> Thanks to datapipe@gmail.com for reporting this [1].
> 
> Also see commit b88e6abc.
> 
> [1] id:"alpine.DEB.2.02.1201132130220.21970@ltspubuntu4.int.smq.datapipe.net"
> ---

+1

Re: [PATCH] configure: update explicit check for glib : >= 2.22

[David Bremner]

On Fri,  3 Feb 2012 13:12:25 +0100, Pieter Praet <pieter@praet.org> wrote:
> As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc',
> which was only introduced in glib 2.22, so update the dependency.

pushed

d