From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Cc: Tomi Ollila <tomi.ollila@iki.fi>
Subject: [PATCH v3 1/6] cli: remove useless talloc_strdup
Date: Sun, 31 Mar 2013 12:45:58 +0300 [thread overview]
Message-ID: <a163d92d4fd1ebde55c57772f58d8b63ac43067c.1364722841.git.jani@nikula.org> (raw)
In-Reply-To: <cover.1364722841.git.jani@nikula.org>
In-Reply-To: <cover.1364722841.git.jani@nikula.org>
If the condition holds, query_string_from_args() has already returned
a talloc allocated empty string. There's no need to duplicate that.
---
notmuch-count.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/notmuch-count.c b/notmuch-count.c
index 390794f..c2f1b7d 100644
--- a/notmuch-count.c
+++ b/notmuch-count.c
@@ -71,10 +71,6 @@ notmuch_count_command (notmuch_config_t *config, int argc, char *argv[])
return 1;
}
- if (*query_str == '\0') {
- query_str = talloc_strdup (config, "");
- }
-
query = notmuch_query_create (notmuch, query_str);
if (query == NULL) {
fprintf (stderr, "Out of memory\n");
--
1.7.10.4
next prev parent reply other threads:[~2013-03-31 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-31 9:45 [PATCH v3 0/6] batch count for notmuch-hello speedup Jani Nikula
2013-03-31 9:45 ` Jani Nikula [this message]
2013-03-31 9:45 ` [PATCH v3 2/6] cli: extract count printing to a separate function in notmuch count Jani Nikula
2013-03-31 9:46 ` [PATCH v3 3/6] cli: add --batch option to " Jani Nikula
2013-03-31 9:46 ` [PATCH v3 4/6] man: document notmuch count --batch and --input options Jani Nikula
2013-03-31 9:46 ` [PATCH v3 5/6] test: " Jani Nikula
2013-03-31 9:46 ` [PATCH v3 6/6] emacs: hello: use batch count Jani Nikula
2013-03-31 16:38 ` [PATCH v3 0/6] batch count for notmuch-hello speedup Tomi Ollila
2013-04-01 13:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a163d92d4fd1ebde55c57772f58d8b63ac43067c.1364722841.git.jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).