From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1 with LMTPS id UJK8JFU2il7RXQAAk0OIDg (envelope-from ) for ; Sun, 05 Apr 2020 19:49:41 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qK2CBFQ2il5DJwAAbx9fmQ (envelope-from ) for ; Sun, 05 Apr 2020 19:49:40 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 9115A683F6F for ; Sun, 5 Apr 2020 18:42:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6685F6DE13F0; Sun, 5 Apr 2020 11:42:08 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9HedB0JJeM5q; Sun, 5 Apr 2020 11:42:07 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 75B956DE13B8; Sun, 5 Apr 2020 11:42:02 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 1786B6DE0F1C for ; Sun, 5 Apr 2020 01:47:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4M9mqqEsvyxx for ; Sun, 5 Apr 2020 01:47:27 -0700 (PDT) X-Greylist: delayed 598 seconds by postgrey-1.36 at arlo; Sun, 05 Apr 2020 01:47:25 PDT Received: from mail-40132.protonmail.ch (mail-40132.protonmail.ch [185.70.40.132]) by arlo.cworth.org (Postfix) with ESMTPS id 10B426DE0B3E for ; Sun, 5 Apr 2020 01:47:25 -0700 (PDT) Date: Sun, 05 Apr 2020 08:37:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1586075844; bh=9TdnH4wyrGoLtxod0eaiFwJWdoDRZ6hBR2M9G4I/pjs=; h=Date:To:From:Reply-To:Subject:From; b=ylOKFGndP+UQh6iFm42zRQtvvMel4+6ysOAVRmC6kmaHP1csE7CU86UH9jbSukHUV XuOxzCuJPd/dls+PkWrgBgzI56yGRAOTqIp95ihywr2bLNDFKO0XNlXS3uk73bfNUB 3tjYqttF6DP6NKQmO84w95c6+pNpxyuftnJ4f4Tw= To: "notmuch@notmuchmail.org" From: Milton Vandersloot Subject: Mark Emacs as prerequisite for tests which require it Message-ID: MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 05 Apr 2020 11:42:00 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Milton Vandersloot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=default; t=1586112134; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=rQpeIdWckxZsQoeWI7XrydkYK57y85h8DYxqizkC/Q8=; b=UaYW/OCbVNhm6CzM7bzYda80xs6fsu09d5FG6d9wGTFL4vFJRMIbn7D4dukAvLT8ArKbrG qsl/zMQ58JoHQlogyIkCRiTu9ekzhlm9zVvR1J3udcSIMbRbcN+lq1e3CbuK/00DdYI0vj YKHXP/ak2HVwnu7tjPS7DQMP+mJr+qM= ARC-Seal: i=1; s=default; d=yhetil.org; t=1586112134; a=rsa-sha256; cv=none; b=UX62Zsjp1bTW4HvAvD9i/oIk6N0s54zqfy7MzXFkh0vR2tmuAMv/8qJkebhL+CTU3rFsyQ FWnKu1gDuygowZoyXoWuXb4AwQoDkVegviiXYOMYt+g8UXA4V49+PYJSP4NKcmUG7g/3VG CyCBkGdzrQWE0fCu7Y7cv9d0kjlxXtM= ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=fail (body hash did not verify) header.d=protonmail.com header.s=default header.b=ylOKFGnd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=protonmail.com (policy=quarantine); spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam: Yes Authentication-Results: aspmx2.migadu.com; dkim=fail (body hash did not verify) header.d=protonmail.com header.s=default header.b=ylOKFGnd; dmarc=fail reason="SPF not aligned (relaxed)" header.from=protonmail.com (policy=quarantine); spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Scan-Result: default: False [10.00 / 13.00]; HAS_REPLYTO(0.00)[miltonrobertvandersloot1412@protonmail.com]; R_SPF_ALLOW(-0.20)[+a:c]; R_DKIM_REJECT(1.00)[protonmail.com:s=default]; FREEMAIL_FROM(0.00)[protonmail.com]; ARC_SIGNED(0.00)[i=1]; IP_REPUTATION_HAM(0.00)[asn: 27017(0.00), country: US(-0.01), ip: 50.126.95.6(0.00)]; DKIM_TRACE(0.00)[protonmail.com:-]; MX_GOOD(-0.50)[cached: notmuchmail.org]; MAILLIST(-0.20)[mailman]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:27017, ipnet:50.126.64.0/18, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[miltonrobertvandersloot1412@protonmail.com,notmuch-bounces@notmuchmail.org]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_POLICY_QUARANTINE(1.50)[protonmail.com : SPF not aligned (relaxed),quarantine]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[protonmail.com]; PREVIOUSLY_DELIVERED(0.00)[notmuch@notmuchmail.org]; HAS_LIST_UNSUB(-0.01)[]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_EQ_ADDR_ALL(0.00)[]; RCVD_COUNT_SEVEN(0.00)[7]; FORGED_SENDER_MAILLIST(0.00)[] X-Scanner: scn0 X-Spam-Score: 10.00 X-TUID: RfWoYXh6sF0w Dear notmuch developers The notmuch test suite depends on some external dependencies to finish successfully (i.e. no failures but maybe some skips), one of them being Emacs. As I had no Emacs installed, I discovered that some tests fail and do not state properly that Emacs is needed for them. Below are small sed commands (was easier this way) which put the "test_require_external_prereq emacs" to the missing places. For some tests (those which test Emacs capabilities) it is clear that Emacs is a necessity, some tests in particular the crypto tests (T350, T355, T357) do require Emacs only for generating a initial mail to index/test on. Here it would in my opinion be better to find an alternative way of producing that e-mail so these tests can be run without Emacs (That would reduce the long list of test names below tremendously). A promising approach would be using the same idea as the last tests in T357-index-decryption.sh, they use "add_email_corpus crypto" for (what seems to me) populating the mail archive. Regards Milton # Mark tests properly which require Emacs # (some of them rely on Emacs to generate an test e-mail) sed -i -e '\:^\..*/test-lib.sh: a test_require_external_prereq emacs' \ test/T310-emacs.sh \ test/T350-crypto.sh \ test/T355-smime.sh \ test/T450-emacs-show.sh \ test/T460-emacs-tree.sh \ test/T730-emacs-forwarding.sh # Most tests in test/T357-index-decryption.sh require a working Emacs. # However, a couple of tests at the end do not. # Mark the tests needing Emacs properly. for testname in \ 'emacs delivery of encrypted message' \ "search for unindexed cleartext" \ 'emacs delivery of encrypted message' \ "emacs delivery of encrypted message, indexed cleartext" \ "emacs search by property for one message" \ "show the message body of the encrypted message" \ "message should go away after deletion" \ "message cleartext not present after insert" \ "stash decryption during show" \ "search should now find the contents" \ "message cleartext is present after reinserting with --decrypt=true" \ "delete all copies of the message" \ "message cleartext is present with insert --decrypt=true" \ 'tagging all messages' \ "verify that tags have not changed" \ 'reindex old messages' \ "reindexed encrypted message, including cleartext" \ "emacs search by property for both messages" \ 'reindex in auto mode' \ "reindexed encrypted messages, should not have changed" \ 'reindex without cleartext' \ "reindexed encrypted messages, without cleartext" \ 'reindex using only session keys' \ "reindexed encrypted messages, decrypting only with session keys" \ "emacs search by property with both messages unindexed" \ "verify that tags remain without cleartext" \ "index cleartext without keeping session keys" \ "Ensure that the indexed terms are present" \ "show one of the messages with --decrypt=true" \ "Ensure that we cannot show the message with --decrypt=auto" \ ; do sed -e "/test_begin_subtest [\"']${testname}[\"']/ a test_require_external_prereq emacs" \ -i test/T357-index-decryption.sh \ || echo "Failed: Marking test ${testname} for skipping." done