unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jeffrey Stedfast <jestedfa@microsoft.com>
To: David Bremner <david@tethera.net>,
	"gmime-devel-list@gnome.org" <gmime-devel-list@gnome.org>
Cc: "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>,
	Alexander Adolf <alexander.adolf@condition-alpha.com>,
	Daniel Kahn Gillmor <dkg@debian.org>
Subject: RE: [EXTERNAL] [gmime-devel] g_mime_multipart_signed_verify and protocol mismatch
Date: Mon, 7 Feb 2022 16:42:18 +0000	[thread overview]
Message-ID: <MN2PR21MB150372F741A526A5EBECA205CF2C9@MN2PR21MB1503.namprd21.prod.outlook.com> (raw)
In-Reply-To: <874k5aol39.fsf@tethera.net>

Hi David,

Yes, I believe that GMime should be fixed to handle this case. It seems reasonable to me that both mime types should be treated as the same in cases like this.

Jeff

-----Original Message-----
From: gmime-devel-list <gmime-devel-list-bounces@gnome.org> On Behalf Of David Bremner
Sent: Monday, February 7, 2022 8:36 AM
To: gmime-devel-list@gnome.org
Cc: notmuch@notmuchmail.org; Alexander Adolf <alexander.adolf@condition-alpha.com>; Daniel Kahn Gillmor <dkg@debian.org>
Subject: [EXTERNAL] [gmime-devel] g_mime_multipart_signed_verify and protocol mismatch


I have a bug report from a notmuch user that notmuch is unable to verify the signature on a message with the following mime structure

└┬╴multipart/signed 29717 bytes
 ├┬╴multipart/related 18125 bytes
 │├┬╴multipart/alternative 14402 bytes
 ││├─╴text/plain 2766 bytes
 ││└─╴text/html 11223 bytes
 │└─╴image/jpeg [image001.jpg] 3372 bytes  └─╴application/pkcs7-signature attachment [smime.p7s] 6979 bytes

The problem seems to be that the outer Content-Type declares

Content-Type: multipart/signed;
	protocol="application/x-pkcs7-signature";

while the actual signature part has

Content-Type: application/pkcs7-signature;

gmime quite correctly reports this as a mismatch, but I wonder if it should be a tolerated mismatch? I saw there is already some attempt in gmime to alias the two content-types, but I didn't follow the scope of that aliasing.

Unfortunately I cannot share the message in question, but if needed I could try to make an artificial test message with the same issue.

All the best,

David


_______________________________________________
gmime-devel-list mailing list
gmime-devel-list@gnome.org
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.gnome.org%2Fmailman%2Flistinfo%2Fgmime-devel-list&amp;data=04%7C01%7Cjestedfa%40microsoft.com%7C80fc53d536d74054f3b508d9ea3ec725%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637798378089381179%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;sdata=0JzRQVHIldHJUe8dsd%2Fsx2tVsZUJScHzEw4VfQIUi0Q%3D&amp;reserved=0\r

      reply	other threads:[~2022-02-07 17:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 13:35 g_mime_multipart_signed_verify and protocol mismatch David Bremner
2022-02-07 16:42 ` Jeffrey Stedfast [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR21MB150372F741A526A5EBECA205CF2C9@MN2PR21MB1503.namprd21.prod.outlook.com \
    --to=jestedfa@microsoft.com \
    --cc=alexander.adolf@condition-alpha.com \
    --cc=david@tethera.net \
    --cc=dkg@debian.org \
    --cc=gmime-devel-list@gnome.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).