From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 79AF36DE00DF for ; Mon, 25 Apr 2016 11:26:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.791 X-Spam-Level: X-Spam-Status: No, score=-0.791 tagged_above=-999 required=5 tests=[AWL=-0.311, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WLyDsYZLCF2j for ; Mon, 25 Apr 2016 11:26:06 -0700 (PDT) Received: from DUB004-OMC4S26.hotmail.com (dub004-omc4s26.hotmail.com [157.55.2.101]) by arlo.cworth.org (Postfix) with ESMTPS id A66996DE00C9 for ; Mon, 25 Apr 2016 11:26:05 -0700 (PDT) Received: from DUB128-W40 ([157.55.2.71]) by DUB004-OMC4S26.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 25 Apr 2016 11:26:03 -0700 X-TMN: [Nui0cloyV9bpZZnd6C6amJpMRZtZx3oV] X-Originating-Email: [dcb314@hotmail.com] Message-ID: From: David Binderman To: David Bremner , "notmuch@notmuchmail.org" Subject: RE: notmuch-0.21 bug report Date: Mon, 25 Apr 2016 18:26:03 +0000 Importance: Normal In-Reply-To: <87wpnlbllb.fsf@zancas.localnet> References: , <87wpnlbllb.fsf@zancas.localnet> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginalArrivalTime: 25 Apr 2016 18:26:03.0727 (UTC) FILETIME=[ECDE9DF0:01D19F1F] X-Mailman-Approved-At: Mon, 25 Apr 2016 21:59:06 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2016 18:26:14 -0000 Hello there=2C=0A= =0A= ----------------------------------------=0A= > Hi David=3B=0A= >=0A= > Thanks for the report. fclose doesn't really make sense here=3B =0A= =0A= Surprising. There is a call to fclose for the success return=2C=0A= so I just assumed that one would also be required for the error return.=0A= =0A= >what is that error message from?=0A= =0A= cppcheck=2C a static analysis tool available from sourceforge.=0A= =0A= =0A= Regards=0A= =0A= David Binderman=0A= =0A= =