From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MC0EK6gTfGFLgwEAgWs5BA (envelope-from ) for ; Fri, 29 Oct 2021 17:30:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qGymJqgTfGFiQAAAbx9fmQ (envelope-from ) for ; Fri, 29 Oct 2021 15:30:48 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C224C25D4A for ; Fri, 29 Oct 2021 17:30:47 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 6EAF61FAA3; Fri, 29 Oct 2021 11:30:42 -0400 (EDT) Received: from anarres.sindominio.net (anarres.sindominio.net [88.99.208.38]) by mail.notmuchmail.org (Postfix) with ESMTPS id B235B1FAA1 for ; Fri, 29 Oct 2021 11:30:39 -0400 (EDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by lesnaus.sindominio.net (Postfix) with ESMTP id 641B23674FF for ; Fri, 29 Oct 2021 17:30:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 lesnaus.sindominio.net 641B23674FF Received: from anarres.sindominio.net ([127.0.0.1]) by localhost (lesnaus.sindominio.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vyN1cqk9cFTy for ; Fri, 29 Oct 2021 17:30:34 +0200 (CEST) Received: by lesnaus.sindominio.net (Postfix, from userid 108) id E7853367506; Fri, 29 Oct 2021 17:30:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 lesnaus.sindominio.net E7853367506 Received: from localhost (unknown [139.47.115.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lesnaus.sindominio.net (Postfix) with ESMTPSA id 5FEDB3674FE; Fri, 29 Oct 2021 17:30:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 lesnaus.sindominio.net 5FEDB3674FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sindominio.net; s=mail; t=1635521430; bh=gUXCU4zsMiMnHDNCkpy52CrJrZ8BlUWrh1/anOYzxvw=; h=Date:Subject:In-Reply-To:Cc:From:To:References:From; b=DWMuVTQelYPBEtF5FvTUyHslEa9vo43Z000SUfqBmyqAytqM/8bWyIOap9iI+NgEb f7jml5DCNsnbo/MMzkuzrBN9PafLflNrlvt87kXDQGX/4wOE1K0UFUtXrTxmDi2X6U xmEH5ebx8APwg64ycLsXDTyob34wTG9ueNeKzhIqyCOnBWNDiCuxuuW2fxQi8oPZB+ G5/5tpzv7l/5Dy36kyUw9Yz/c3dYBnCHnXLsbhte7/Sd5JOFZt2qQfAM2iRhi/p4OR PoMbRYmntyz4GQKPi6wJBCu6AyCW2tMUh7r57NP9LMwKSElE18HbMDg74/3nN3LqEV 3o02PUju7KepF3C203YMvN1BeJPsx6ngYtcCBeY3E8NOc+zcOs/zzSX+AKvaU8eoMJ ye2qAqVaJQt+K7H1svBmwA/DMaAE52wsN+hpu0V3+AzmQU21SU2ylQfx2hWlSr5ijp MMjihOxZzCdFZ4tP5rSdrJ8/aaGZORi1/yq16U9PvlBIsh5h4lkwcE9NjQ+BSY2pRR LiN6GFGl3Vh94vstOGei7cUrS8QAAm5kZtcFk67q25/eXyaN52VEfaW0rLxLNgchb2 3nDicDrC8uKN7kDID96RO6P/gmRPihRwVWIx0+viZshl7mdmc1gbr0YwgFLnZiGaWg 4vklLlA6IcBtWDbm6rOoD514= Mime-Version: 1.0 Date: Fri, 29 Oct 2021 17:30:23 +0200 Message-Id: Subject: Re: [PATCH] emacs: don't add space to tag completion candidates. In-Reply-To: <20211023170524.1897961-1-david@tethera.net> From: "inwit" To: "David Bremner" , "Tomi Ollila" , "David Edmondson" , "Alan Schmitt" , "notmuch" References: <20211023170524.1897961-1-david@tethera.net> Message-ID-Hash: B7TWFQUSX75K5ZD4FABHATF7TFLZL7EE X-Message-ID-Hash: B7TWFQUSX75K5ZD4FABHATF7TFLZL7EE X-MailFrom: inwit@sindominio.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635521447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=XZHfqJqiBtl9FUsvtUS16Bpqbv8NUDSWVGWk5UskP7U=; b=tGTdidMbLQP8zTjLazrqeKgSfvInlYVC8MgoqYC8tOVoxIBu2bBYjc8eQbj0yQj+YNxI02 0MUTWHPBEngaYDCwcIncJpM3+bJDIpreYCOFxQEUtyLH0oKksM6ViwlBhozMjIzmQXsJ6p 7nBu+tOoNDdvIuoP6TfZymMD5exJDgKmD57kDgo9GnpYS37SXM4+AHpqudM2gE+BZP2nIv w9iHkaTibrI+QBJWvRjo2rI//Lq2sf4Ij15kWkINIQe3XlKLXBYEQbMMKearVdE10g8aRd ap8QjRwcW82vMczAsXLfWWlmWQesZyOZUIRzs/puSlBkBNz6bK2oIHqe524sVA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635521447; a=rsa-sha256; cv=none; b=qa0JC1+Pyw6u2RQE/0dZWIgShhTA2GB/sdRThNJJ0Mo6P1i1/tmsIC31PyH+GuW3BrWR3E yZjwBaB4bt8cDUpwxEUhf86B2yikYYlV2SvcUR2sfaNcpNlBPisBJ+Y6ggqs1Ly42I2EA2 xZc9xptItooMyQ3o3/kmJwbjxG4PY05f9UUO21wlUlqTjfxC9jSpG3Rfsj3SicONnRaM4B sae166/RHzVWCpE0z9o8lzJ7EQGcuauy+NkOFXpjq5nCQeUPLyvASpyEk69n/KGdYAOU0R JavC6RFm5Un+/gq1Rj4jqQEWUKYlqyYLi8CtzaGz86TuCuE1qgIXFUJu09vjVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=sindominio.net header.s=mail header.b=DWMuVTQe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=sindominio.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=sindominio.net header.s=mail header.b=DWMuVTQe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=sindominio.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C224C25D4A X-Spam-Score: 0.25 X-Migadu-Scanner: scn0.migadu.com X-TUID: SJVjBra9S4Lk Works as expected under selectrum! Thanks! On Sat Oct 23, 2021 at 7:05 PM CEST, David Bremner wrote: > Apparently this messes up various third party completion > frameworks. This change does mean that users will have to hit space > after completing a tag change in order to enter another change. > > As a bonus, remove the call to #'delete, since > completing-read-multiple already promises to remove empty strings. > --- > emacs/notmuch-tag.el | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el > index 536315e9..145f309f 100644 > --- a/emacs/notmuch-tag.el > +++ b/emacs/notmuch-tag.el > @@ -429,17 +429,9 @@ initial input in the minibuffer." > (set-keymap-parent map crm-local-completion-map) > (define-key map " " 'self-insert-command) > map))) > - (delete "" (completing-read-multiple > - prompt > - ;; Append the separator to each completion so when the > - ;; user completes a tag they can immediately begin > - ;; entering another. `completing-read-multiple' > - ;; ultimately splits the input on crm-separator, so we > - ;; don't need to strip this back off (we just need to > - ;; delete "empty" entries caused by trailing spaces). > - (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list) > - nil nil initial-input > - 'notmuch-read-tag-changes-history)))) > + (completing-read-multiple prompt tag-list > + nil nil initial-input > + 'notmuch-read-tag-changes-history))) > > ;;; Tagging > > -- > 2.33.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org