From: "inwit" <inwit@sindominio.net>
To: "David Bremner" <david@tethera.net>,
"Tomi Ollila" <tomi.ollila@iki.fi>,
"David Edmondson" <dme@dme.org>,
"Alan Schmitt" <alan.schmitt@polytechnique.org>,
"notmuch" <notmuch@notmuchmail.org>
Subject: Re: [PATCH] emacs: don't add space to tag completion candidates.
Date: Fri, 29 Oct 2021 17:30:23 +0200 [thread overview]
Message-ID: <CFBZYHEIXKZC.2PGICAHKEJSLN@bisio> (raw)
In-Reply-To: <20211023170524.1897961-1-david@tethera.net>
Works as expected under selectrum! Thanks!
On Sat Oct 23, 2021 at 7:05 PM CEST, David Bremner wrote:
> Apparently this messes up various third party completion
> frameworks. This change does mean that users will have to hit space
> after completing a tag change in order to enter another change.
>
> As a bonus, remove the call to #'delete, since
> completing-read-multiple already promises to remove empty strings.
> ---
> emacs/notmuch-tag.el | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 536315e9..145f309f 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -429,17 +429,9 @@ initial input in the minibuffer."
> (set-keymap-parent map crm-local-completion-map)
> (define-key map " " 'self-insert-command)
> map)))
> - (delete "" (completing-read-multiple
> - prompt
> - ;; Append the separator to each completion so when the
> - ;; user completes a tag they can immediately begin
> - ;; entering another. `completing-read-multiple'
> - ;; ultimately splits the input on crm-separator, so we
> - ;; don't need to strip this back off (we just need to
> - ;; delete "empty" entries caused by trailing spaces).
> - (mapcar (lambda (tag-op) (concat tag-op crm-separator)) tag-list)
> - nil nil initial-input
> - 'notmuch-read-tag-changes-history))))
> + (completing-read-multiple prompt tag-list
> + nil nil initial-input
> + 'notmuch-read-tag-changes-history)))
>
> ;;; Tagging
>
> --
> 2.33.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
next prev parent reply other threads:[~2021-10-29 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 8:24 notmuch-tag failing on trailing space alan.schmitt
2021-07-27 9:37 ` Tomi Ollila
2021-08-16 9:03 ` Alan Schmitt
2021-08-16 15:17 ` David Bremner
2021-08-16 15:48 ` David Edmondson
2021-08-17 5:52 ` Tomi Ollila
2021-10-23 17:05 ` [PATCH] emacs: don't add space to tag completion candidates David Bremner
2021-10-29 15:30 ` inwit [this message]
2021-10-30 9:31 ` David Bremner
2021-10-31 19:34 ` Tomi Ollila
2021-12-04 16:59 ` David Bremner
2021-08-16 15:52 ` notmuch-tag failing on trailing space Alan Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CFBZYHEIXKZC.2PGICAHKEJSLN@bisio \
--to=inwit@sindominio.net \
--cc=alan.schmitt@polytechnique.org \
--cc=david@tethera.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).