From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SB0vOeyCLmHWMQAAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 21:28:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wI+KNOyCLmGkCwAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 19:28:44 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CA56BF26 for ; Tue, 31 Aug 2021 21:28:43 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 4EC7120682; Tue, 31 Aug 2021 15:28:40 -0400 (EDT) Received: from anarres.sindominio.net (mail.sindominio.net [IPv6:2a01:4f8:10a:3925::4]) by mail.notmuchmail.org (Postfix) with ESMTPS id AB22420675 for ; Tue, 31 Aug 2021 15:28:37 -0400 (EDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by lesnaus.sindominio.net (Postfix) with ESMTP id CFEC03650B4 for ; Tue, 31 Aug 2021 21:28:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 lesnaus.sindominio.net CFEC03650B4 Received: from anarres.sindominio.net ([127.0.0.1]) by localhost (lesnaus.sindominio.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YtZvN75We79H for ; Tue, 31 Aug 2021 21:28:34 +0200 (CEST) Received: by lesnaus.sindominio.net (Postfix, from userid 108) id 17F923650AE; Tue, 31 Aug 2021 21:28:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 lesnaus.sindominio.net 17F923650AE Received: from localhost (243.red-37-10-132.dynamicip.rima-tde.net [37.10.132.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lesnaus.sindominio.net (Postfix) with ESMTPSA id D85253650AD; Tue, 31 Aug 2021 21:28:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 lesnaus.sindominio.net D85253650AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sindominio.net; s=mail; t=1630438112; bh=ROx+hS4TVEufffl5drBMrBqGs/7kQlLm+k47ZQ6rUHM=; h=Date:From:To:Subject:In-Reply-To:Cc:References:From; b=bq9/zA4SJM3wV+48/sDWHQdflV7VrPPCFl7peRQW+j6AqZ8j+VJDHIIZWbgz6CAIp DCqy7pTQsKV1g2ipvzSm4xgy3Bh0ETj55F62h8P3XAymDZBtYErLSeMR6Nh3qewoix yl9hpY28Jg6GchY7mpWPPi6E5YaW56aKsdcYx5lJgQxNJuZMNl3abvVZo3n7kGSMOb qFAdVoJn0c+KAEsz9+tiwPCuPt/AgDEUjUeuX4po1efEs7lwLxRFpIUpK9C13dnqnW q7/tBSQKKr0g5icPtGQc59PuEz0JT5++rNgnKBPFLYjlBxQNLGA+NyzZP5ZKNyDqDw 6+li3JKwN9WR8ioQ/l9f2i2f/wdCSlUzvHZRecRceYC+FCjinDM+1dz+P8UutmUmJ5 Xuvgy431oJddfmPwNPQR4n3wqdTZhkOlqKIjHysr36UcDLY6pLg7gv3/+wWpTMO7ZR B2upKEKePlYQmc/KWXcMv4881ZQODGXrWT3G3K9y01VDIMB21FlTNfU8X7+ZPFur6j 9Ga6DR9l7ecr7rY8LITpX3wCxBexzGRz6HQjjPTrri/z8uROr9P0TcRndbn4f8HkmC UVCFG4V2EVwEomxXUX1706AlpvoEOlKvTdcUPJerRJaMxWHawOz7aMeZqr/EumIEwK G0Lkogn9EJezPDgl5fSipKkA= Mime-Version: 1.0 Date: Tue, 31 Aug 2021 21:28:30 +0200 Message-Id: From: "inwit" To: "David Bremner" , Subject: Re: [PATCH] emacs: Re-apply an old patch to fold/unfold threads in tree-view In-Reply-To: <87y28h4pcn.fsf@tethera.net> References: <20210831110111.3148499-1-inwit@sindominio.net> <87y28h4pcn.fsf@tethera.net> Message-ID-Hash: LWUPNSOX37333VARPK4Y5DV33KBMNL32 X-Message-ID-Hash: LWUPNSOX37333VARPK4Y5DV33KBMNL32 X-MailFrom: inwit@sindominio.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Julien Masson X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630438124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=d9Gb9vCVn1BUzARtLq+o5oKvogIBJWdExsiuICXYpP8=; b=AhVVHzBCPK4w5WoQ+kD1aKFLLsNVMCXm3kYhCvMTncahncWdJBYjQUdWJWNRulgA2jJfuV zG7AMl27eGUa2tYlWc5MbmbMmC24wM0r9LtTtES/Loo2Dujncc5rLL/UNNGQmchFcUG+le EcodvTTnXB7qP8iM4reontqgjQWcjZFE6+9H8U4qtKswzSDLfP71cZ4jLClIKG3dZFqCO4 VW8uzU+lpWYEqoFzvQQUCNQbJqYVQHp8yJp9nuYhYN9n2hQi2Zy6FDeL0c24kk4iI5lUaM 2kL/e7SKI9l3kLDTNv/YJUM54Ep1GzRZtcKK+EVq846W5XkYCiR6A3zPMKg9kg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630438124; a=rsa-sha256; cv=none; b=SCh4CDy/6IGvM1oz2FwgiUG+H5QI8NFBPMCvYi70bCC7kOuzAn4gcb99AAm5TADoZcT2uY wE5J7e8/IAaOlu4ZKzvYMb3huwjOqYGaly7T5vxWCcyg6OMRwDK1LzDT13w8jOF1C31sWj KIKdWxS+k1lQqJLl8Wsotw29KYutIrugQaLNXzXzrEslb2joEGO71xLQLF7W/gJEOUZta2 y5JzPQx7ufMe6U0ufkWhgrw8plb9ZX0e2ie1PX9XZnJOlJ+zescG9rHVdOOdJjmWRZG0kl sppUYIAhSXmvK62kIbXa9qP/62udDgU2oa1Zg2CzNIHtVHPhFkq9U6MtpyJM3w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=sindominio.net header.s=mail header.b="bq9/zA4S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=sindominio.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=sindominio.net header.s=mail header.b="bq9/zA4S"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=sindominio.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: CA56BF26 X-Spam-Score: 0.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: k9fP6qDHAaQv On Tue Aug 31, 2021 at 5:15 PM CEST, David Bremner wrote: > Thanks for reviving this. My pleasure. > Eventually you'll want to add a proper commit > message and address some of the previous review. Will do, eventually (see below). > There seems to be problems introducing this overlay. I either don't > see it, or it is added to the wrong buffer. I've seen it too. From what I've tried, it happens when you try to fold the last thread on a buffer. > For me the tree-view goes away and [...] is applied to the *scratch* > buffer. I suspect this bug was in the original patch. Yeah, since I haven't really done anything, the original patch is indeed to blame. My main problem is that I don't really know where to start debugging it. I'm afraid my elisp powers don't reach that far. :( > About the binding, have a look at devel/emacs-key-bindings.org to help > choose a key; a final version of the patch should update that file and > doc/notmuch-emacs.rst Will do. In case we can fix the bug. Regards,