unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "inwit" <inwit@sindominio.net>
To: "David Bremner" <david@tethera.net>, <notmuch@notmuchmail.org>
Cc: Julien Masson <massonju.eseo@gmail.com>
Subject: Re: [PATCH] emacs: Re-apply an old patch to fold/unfold threads in tree-view
Date: Tue, 31 Aug 2021 21:28:30 +0200	[thread overview]
Message-ID: <CDXY2NOBR29C.JPEDM8DQF8O7@bisio> (raw)
In-Reply-To: <87y28h4pcn.fsf@tethera.net>

On Tue Aug 31, 2021 at 5:15 PM CEST, David Bremner wrote:
> Thanks for reviving this.
My pleasure.

> Eventually you'll want to add a proper commit
> message and address some of the previous review.
Will do, eventually (see below).

> There seems to be problems introducing this overlay. I either don't
> see it, or it is added to the wrong buffer.
I've seen it too. From what I've tried, it happens when you try to fold
the last thread on a buffer.

> For me the tree-view goes away and [...] is applied to the *scratch*
> buffer. I suspect this bug was in the original patch.
Yeah, since I haven't really done anything, the original patch is indeed
to blame.

My main problem is that I don't really know where to start debugging it.
I'm afraid my elisp powers don't reach that far. :(

> About the binding, have a look at devel/emacs-key-bindings.org to help
> choose a key; a final version of the patch should update that file and
> doc/notmuch-emacs.rst
Will do. In case we can fix the bug.

Regards,

      reply	other threads:[~2021-08-31 19:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31 11:01 [PATCH] emacs: Re-apply an old patch to fold/unfold threads in tree-view inwit
2021-08-31 15:15 ` David Bremner
2021-08-31 19:28   ` inwit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CDXY2NOBR29C.JPEDM8DQF8O7@bisio \
    --to=inwit@sindominio.net \
    --cc=david@tethera.net \
    --cc=massonju.eseo@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).