From: Ethan <ethan.glasser.camp@gmail.com>
To: Austin Clements <amdragon@mit.edu>
Cc: notmuch mailing list <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links
Date: Mon, 19 Nov 2012 23:50:48 -0500 [thread overview]
Message-ID: <CAOJ+Ob3ju_K-HpH+kZtK0HF9g+PGZNdwW6RQ2FcMUxChvZ89Kw@mail.gmail.com> (raw)
In-Reply-To: <20121120042302.GF22284@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
On Mon, Nov 19, 2012 at 11:23 PM, Austin Clements <amdragon@mit.edu> wrote:
> This seems like overkill given that all of the common code in
> notmuch-tagger-{body,header}-button-action is already abstracted into
> a common function. Were there other places where code was duplicated
> because of the difference between regular buttons and header buttons?
>
I guess you're right, that's the only place and it isn't worth worrying
about.
Ethan
[-- Attachment #2: Type: text/html, Size: 731 bytes --]
next prev parent reply other threads:[~2012-11-20 4:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 19:18 [PATCH v2] emacs: display tags in notmuch-show with links Damien Cassou
2012-11-18 19:18 ` [PATCH 1/4] Add a thread's tags to emacs header-line Damien Cassou
2012-11-20 5:13 ` Austin Clements
2012-11-20 5:32 ` Austin Clements
2012-11-22 18:36 ` Damien Cassou
2012-11-18 19:18 ` [PATCH 2/4] Make tags in header-line clickable Damien Cassou
2012-11-18 19:18 ` [PATCH 3/4] emacs: Make tags that appear in `notmuch-show' clickable Damien Cassou
2012-11-18 23:06 ` Mark Walters
2012-11-22 18:40 ` Damien Cassou
2012-11-22 18:46 ` Mark Walters
2012-11-23 8:02 ` Bernard Hurley
2012-11-23 11:18 ` Tomi Ollila
2012-11-30 16:15 ` Damien Cassou
2012-11-20 5:32 ` Austin Clements
2012-11-30 16:13 ` Damien Cassou
2012-11-18 19:18 ` [PATCH 4/4] emacs: Add unit-tests for clickable tags in notmuch-show Damien Cassou
2012-11-18 22:59 ` [PATCH v2] emacs: display tags in notmuch-show with links Ethan Glasser-Camp
2012-11-19 0:10 ` Aaron Ecay
2012-11-20 4:23 ` Austin Clements
2012-11-20 4:50 ` Ethan [this message]
2012-11-22 18:11 ` Damien Cassou
-- strict thread matches above, loose matches on Subject: below --
2012-11-10 16:41 Damien Cassou
2012-11-14 2:03 ` Ethan Glasser-Camp
2012-11-15 15:09 ` Damien Cassou
2012-11-14 12:41 ` Mark Walters
2012-11-15 15:42 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJ+Ob3ju_K-HpH+kZtK0HF9g+PGZNdwW6RQ2FcMUxChvZ89Kw@mail.gmail.com \
--to=ethan.glasser.camp@gmail.com \
--cc=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).