unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Ethan <ethan.glasser.camp@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [RFC PATCH 00/14] modular mail stores based on URIs
Date: Thu, 28 Jun 2012 14:39:55 -0400	[thread overview]
Message-ID: <CAOJ+Ob0=N=AgZ+HWu_2U3yP1ro+Cfv5JmoJzb+2BxzndV-9mwQ@mail.gmail.com> (raw)
In-Reply-To: <87txxvuyn4.fsf@servo.finestructure.net>

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

It is pretty big and there are a couple places where the series could be
simplified, the first patch in particular. I will break it out and resubmit
piecewise but I'd like to know how to address these particular issues:

1. Are URIs the way to specify individual messages, despite bremner's
concerns about too much of the API being strings? Is adding another library
is the easiest way to parse URIs?

2. Is it OK to break maildir relocatability, or is it worth it to pass more
config to the library (perhaps by adding it to the notmuch_database_t
object)?

3. Is a global variable in the library acceptable? (I don't see any
others.) If not, how to store mailstore state?

The patch series is really more like a very rough draft to try to give
these concerns a context (specifically, mbox support).

Ethan

[-- Attachment #2: Type: text/html, Size: 871 bytes --]

  reply	other threads:[~2012-06-28 18:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-25 20:41 [RFC PATCH 00/14] modular mail stores based on URIs Ethan Glasser-Camp
2012-06-25 20:41 ` [RFC PATCH 01/14] All access to mail files goes through the mailstore module Ethan Glasser-Camp
2012-06-28 20:48   ` Mark Walters
2012-06-25 20:41 ` [RFC PATCH 02/14] Introduce uriparser Ethan Glasser-Camp
2012-06-25 20:41 ` [RFC PATCH 03/14] mailstore can read from maildir: URLs Ethan Glasser-Camp
2012-06-25 20:41 ` [RFC PATCH 04/14] Not all filenames need to be converted to absolute paths Ethan Glasser-Camp
2012-06-27  9:17 ` [RFC PATCH 00/14] modular mail stores based on URIs Mark Walters
2012-06-28  7:39   ` Ethan
2012-06-28 15:13     ` David Bremner
2012-06-28 20:41       ` Robert Horn
2012-06-28 20:45     ` Mark Walters
2012-07-01 16:02       ` Ethan
2012-07-01 16:39         ` [PATCH v2 0/8] URI-based modular mail stores Ethan Glasser-Camp
2012-07-01 16:39           ` [PATCH v2 1/8] All access to mail files goes through the mailstore module Ethan Glasser-Camp
2012-07-01 19:48             ` Mark Walters
2012-07-01 16:39           ` [PATCH v2 2/8] Introduce uriparser Ethan Glasser-Camp
2012-07-01 16:39           ` [PATCH v2 3/8] Not all filenames need to be converted to absolute paths Ethan Glasser-Camp
2012-07-01 16:39           ` [PATCH v2 4/8] new: add "scan" option Ethan Glasser-Camp
2012-07-01 16:39           ` [PATCH v2 5/8] notmuch-new: pull out useful bits of add_files_recursive Ethan Glasser-Camp
2012-07-01 19:55             ` Mark Walters
2012-07-01 16:39           ` [PATCH v2 6/8] mailstore: support for mbox:// URIs Ethan Glasser-Camp
2012-07-01 16:39           ` [PATCH v2 7/8] Tests for mbox support Ethan Glasser-Camp
2012-07-01 16:39           ` [PATCH v2 8/8] new: Add scan support for mbox:// URIs Ethan Glasser-Camp
2012-07-01 16:48         ` [RFC PATCH 00/14] modular mail stores based on URIs Mark Walters
2012-07-03  8:40         ` Jameson Graef Rollins
2012-06-28 17:36 ` Jameson Graef Rollins
2012-06-28 18:39   ` Ethan [this message]
2012-06-28 22:00 ` Mark Walters
2012-06-29  6:43   ` Ethan
2012-06-29  7:00     ` Mark Walters
2012-06-29  7:43     ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOJ+Ob0=N=AgZ+HWu_2U3yP1ro+Cfv5JmoJzb+2BxzndV-9mwQ@mail.gmail.com' \
    --to=ethan.glasser.camp@gmail.com \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).