[PATCH] Fix typo in Message.maildir_flags_to_tags

[PATCH] Fix typo in Message.maildir_flags_to_tags

[Jaime Velasco Juan]

It has been calling _tags_to_maildir_flags instead since the beginning,
---
 bindings/python/notmuch/message.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py
index bf80900..fc177eb 100644
--- a/bindings/python/notmuch/message.py
+++ b/bindings/python/notmuch/message.py
@@ -572,7 +572,7 @@ class Message(Python3StringMixIn):
             notmuch.STATUS.SUCCESS here. See there for details."""
         if not self._msg:
             raise NotInitializedError()
-        return Message._tags_to_maildir_flags(self._msg)
+        return Message._maildir_flags_to_tags(self._msg)
 
     def __repr__(self):
         """Represent a Message() object by str()"""
-- 
2.8.1

Re: [PATCH] Fix typo in Message.maildir_flags_to_tags

[Jaime Velasco]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

Hi, is there anything I can fix to get the patch commited?

Regards

2016-07-04 19:49 GMT+01:00 Jaime Velasco Juan <jsagarribay@gmail.com>:

> It has been calling _tags_to_maildir_flags instead since the beginning,
> ---
>  bindings/python/notmuch/message.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bindings/python/notmuch/message.py
> b/bindings/python/notmuch/message.py
> index bf80900..fc177eb 100644
> --- a/bindings/python/notmuch/message.py
> +++ b/bindings/python/notmuch/message.py
> @@ -572,7 +572,7 @@ class Message(Python3StringMixIn):
>              notmuch.STATUS.SUCCESS here. See there for details."""
>          if not self._msg:
>              raise NotInitializedError()
> -        return Message._tags_to_maildir_flags(self._msg)
> +        return Message._maildir_flags_to_tags(self._msg)
>
>      def __repr__(self):
>          """Represent a Message() object by str()"""
> --
> 2.8.1
>
>

[-- Attachment #2: Type: text/html, Size: 1480 bytes --]

Re: [PATCH] Fix typo in Message.maildir_flags_to_tags

[David Bremner]

Jaime Velasco <jsagarribay@gmail.com> writes:

> Hi, is there anything I can fix to get the patch commited?
>
> Regards

Hi Juan;

Thanks for the ping. I was waiting for justus to have a look, since he's
mainly maintaining the python bindings. If nothing happens in the next
week, I'll merge it myself. Feel free to remind me if that doesn't
happen.

d

Re: [PATCH] Fix typo in Message.maildir_flags_to_tags

[David Bremner]

David Bremner <david@tethera.net> writes:

> Jaime Velasco <jsagarribay@gmail.com> writes:
>
>> Hi, is there anything I can fix to get the patch commited?
>>
>> Regards
>
> Hi Juan;
>
> Thanks for the ping. I was waiting for justus to have a look, since he's
> mainly maintaining the python bindings. If nothing happens in the next
> week, I'll merge it myself. Feel free to remind me if that doesn't
> happen.
>
> d

Also, sorry I got your name wrong.

d

Re: [PATCH] Fix typo in Message.maildir_flags_to_tags

[Jaime Velasco Juan]

David Bremner <david@tethera.net> writes:

> David Bremner <david@tethera.net> writes:
>
>> Jaime Velasco <jsagarribay@gmail.com> writes:
>>
>>> Hi, is there anything I can fix to get the patch commited?
>>>
>>> Regards
>>
>> Hi Juan;
>>
>> Thanks for the ping. I was waiting for justus to have a look, since he's
>> mainly maintaining the python bindings. If nothing happens in the next
>> week, I'll merge it myself. Feel free to remind me if that doesn't
>> happen.
>>
>> d
>
> Also, sorry I got your name wrong.
>
> d

So... ping?

Re: [PATCH] Fix typo in Message.maildir_flags_to_tags

[David Bremner]

Jaime Velasco Juan <jsagarribay@gmail.com> writes:


> So... ping?

merged to master

d