From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH v2 2/3] reply: add message-id header
Date: Wed, 18 Apr 2012 11:27:50 -0600 [thread overview]
Message-ID: <CAMoJFUvcd+-b6VR7Mg3qfccZ1TUy3puMb12gAyaqJ0fyVV4uMg@mail.gmail.com> (raw)
In-Reply-To: <87zka9b2zl.fsf@nikula.org>
On Wed, Apr 18, 2012 at 07:09, Jani Nikula <jani@nikula.org> wrote:
> I do wonder whether the emacs ui / message mode will add a duplicate
> message-id rather than override this.
I think the emacs reply code will replace Message-ID and User-Agent
headers correctly, as it does with the From header when selecting a
different identity within emacs. But, this should be tested.
Ideally, the emacs tests should catch any problems here. As things are
right now, I think we would catch problems with the User-Agent header
in the reply tests: the tests replace the emacs and notmuch versions
with XXX but otherwise leave the header intact, so it should differ
from the one generated by notmuch compose.
The Message-ID is trickier, since in emacs it's generated when the
message is sent, not when the message is created, and thus the reply
tests don't see it at all. The "Sending a message via (fake) SMTP"
test could potentially catch problems, but currently the tests don't
try to predict the Message-ID emacs will give the message, so they
replace it with XXX.
-- Adam
next prev parent reply other threads:[~2012-04-18 17:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 12:39 [PATCH v2 0/3] composing patches Felipe Contreras
2012-04-18 12:39 ` [PATCH v2 1/3] Add 'compose' command Felipe Contreras
2012-04-18 13:06 ` Jani Nikula
2012-04-18 13:34 ` Felipe Contreras
2012-04-18 13:43 ` Dmitry Kurochkin
2012-04-18 14:11 ` Felipe Contreras
2012-04-18 14:41 ` Dmitry Kurochkin
2012-04-18 15:45 ` Felipe Contreras
2012-04-18 14:20 ` Jani Nikula
2012-04-18 15:39 ` Felipe Contreras
2012-04-18 16:00 ` Tomi Ollila
2012-04-18 16:10 ` Dmitry Kurochkin
2012-04-18 16:34 ` Jani Nikula
2012-04-19 9:31 ` Tomi Ollila
2012-04-19 14:03 ` Felipe Contreras
2012-04-18 12:39 ` [PATCH v2 2/3] reply: add message-id header Felipe Contreras
2012-04-18 13:09 ` Jani Nikula
2012-04-18 17:27 ` Adam Wolfe Gordon [this message]
2012-04-18 19:44 ` Felipe Contreras
2012-04-18 12:39 ` [PATCH v2 3/3] reply: add user-agent field Felipe Contreras
2012-04-18 17:36 ` [PATCH v2 0/3] composing patches Adam Wolfe Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMoJFUvcd+-b6VR7Mg3qfccZ1TUy3puMb12gAyaqJ0fyVV4uMg@mail.gmail.com \
--to=awg+notmuch@xvx.ca \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).