From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1C93C431FC4 for ; Sun, 6 May 2012 07:29:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p5LIpKDsHqYH for ; Sun, 6 May 2012 07:29:40 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 065D8431FAE for ; Sun, 6 May 2012 07:29:39 -0700 (PDT) Received: by lbbgk8 with SMTP id gk8so3287765lbb.26 for ; Sun, 06 May 2012 07:29:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:x-originating-ip:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=gHpdAv1/xw7S9awNt0lnCiswB7ZpZCqR0uyNFWqL3bA=; b=DuBipOQZvKU3Z852JzzpCKGi8mBN/+98VTQg5ay3fnUbnATW67xurHCTivDwebqy3g OtMtgCPLPGPgkECTPSpy+xxZQZy6c8HnV9V+NoKFDWD1WGjJ7ivqqvvA3XO1Kdbd/jjW lpfCAEG77p9LauoxoKk4tHsx8gZH/U3NIQC7mJcclzhSZ/d4jjGCrS7ACptRAzXDH7v9 Frw0AIV73zmny+1l+3z+W46Ku5eH6Vc+SBAuLBDmuamaC19WjPIh89gHHWlOqq/aB+yi 65lQTz6cd650AWdysZvuayLKlvHQw4+q7wlRqPTNKkAnMLFeEKZtWDAl3ZbHJ5y5s5U+ zIIQ== MIME-Version: 1.0 Received: by 10.112.29.99 with SMTP id j3mr5797998lbh.47.1336314576992; Sun, 06 May 2012 07:29:36 -0700 (PDT) Sender: awg@xvx.ca Received: by 10.112.82.163 with HTTP; Sun, 6 May 2012 07:29:36 -0700 (PDT) X-Originating-IP: [96.52.216.56] In-Reply-To: <878vh5bja3.fsf@zancas.localnet> References: <1336245869-32699-1-git-send-email-awg+notmuch@xvx.ca> <878vh5bja3.fsf@zancas.localnet> Date: Sun, 6 May 2012 08:29:36 -0600 X-Google-Sender-Auth: 479i6z4X5wRd9ZYNEKXoWGm1h1s Message-ID: Subject: Re: [PATCH v2 0/2] Replying to HTML-only emails, v2 From: Adam Wolfe Gordon To: David Bremner Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQkn1DqNAdVdKSdY40RB4YZ5tNzzrxUnaKqiurox8yj8rEfNHWAesI0cZj2pmwXoc7GEO7wu Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2012 14:29:41 -0000 On Sun, May 6, 2012 at 6:12 AM, David Bremner wrote: > I pushed this series, but it seems to have a test failure on the > buildbot (it's fine on my Debian wheezey box) > > http://buildbot.notmuchmail.org/builders/master/builds/198/steps/tests/logs/problems > > Maybe you and Tom could try to figure out what is different about his > environment? The failure is on the new HTML reply test, and the difference in the output is just indentation - the quoted HTML text has an extra three spaces at the beginning of each line. So, it's almost certainly a difference in emacs versions or packages. I'm running Ubuntu Oneiric with emacs 23.3. It looks like the relevant variable in mm is mm-text-html-renderer-alist, which defines various methods of parsing HTML. For me it's: ((w3 . mm-inline-text-html-render-with-w3) (w3m . mm-inline-text-html-render-with-w3m) (w3m-standalone . mm-inline-text-html-render-with-w3m-standalone) (links mm-inline-render-with-file mm-links-remove-leading-blank "links" "-dump" file) (lynx mm-inline-render-with-stdin nil "lynx" "-dump" "-force_html" "-stdin" "-nolist") (html2text mm-inline-render-with-function html2text)) I get the behavior seen on the buildbot if the only option available on my machine is lynx, so I'm guessing that's what's happening. I'm not sure what the best option is for fixing this. A few possible options: * Only run the test if links, w3m, or w3m.el is available. * Make the test accept differences in whitespace. * Try to produce HTML for the test that renders the same in every method. Opinions from anyone? -- Adam