From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <awg@xvx.ca>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 54323431FD0
	for <notmuch@notmuchmail.org>; Mon,  9 Jan 2012 17:59:49 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 0xtiUmtHIcgk for <notmuch@notmuchmail.org>;
	Mon,  9 Jan 2012 17:59:49 -0800 (PST)
Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
	[209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id BFCA2431FB6
	for <notmuch@notmuchmail.org>; Mon,  9 Jan 2012 17:59:48 -0800 (PST)
Received: by bkat2 with SMTP id t2so96988bka.26
	for <notmuch@notmuchmail.org>; Mon, 09 Jan 2012 17:59:47 -0800 (PST)
MIME-Version: 1.0
Received: by 10.204.133.207 with SMTP id g15mr7926541bkt.17.1326160787288;
	Mon, 09 Jan 2012 17:59:47 -0800 (PST)
Sender: awg@xvx.ca
Received: by 10.205.33.73 with HTTP; Mon, 9 Jan 2012 17:59:47 -0800 (PST)
X-Originating-IP: [12.50.241.130]
In-Reply-To: <m2ty45is1j.fsf@gmail.com>
References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>
	<1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
	<m2ty45is1j.fsf@gmail.com>
Date: Mon, 9 Jan 2012 18:59:47 -0700
X-Google-Sender-Auth: GKHrDdRRNkVViLiBIWg3KAtSaN8
Message-ID: <CAMoJFUu=vNcud1HpSDE9tapd8XA+HXQTD9z3_zhH-zA3EqMXqQ@mail.gmail.com>
Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Aaron Ecay <aaronecay@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jan 2012 01:59:49 -0000

On Sun, Jan 8, 2012 at 18:27, Aaron Ecay <aaronecay@gmail.com> wrote:
>> +(defun w3m-region (start end)) ;; From `w3m.el'.
>
> What is the purpose of the above line? =A0If it is to make the compiler
> aware of the function, you should use =91declare-function=92 instead. =A0=
Defun
> will erase the original definition of the w3m-region function.

Indeed, it's to make the compiler aware of the function.  I followed
the example of notmuch-show.el (defvar w3m-current-buffer, line 391),
but it sounds like declare-function is a better way to accomplish
this.  I haven't written a whole lot of emacs lisp, so thanks for the
tip.

Given David's comments about requiring w3m instead it might be moot,
but if not I'll make this change for the next version.