From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Aaron Ecay <aaronecay@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
Date: Mon, 9 Jan 2012 18:59:47 -0700 [thread overview]
Message-ID: <CAMoJFUu=vNcud1HpSDE9tapd8XA+HXQTD9z3_zhH-zA3EqMXqQ@mail.gmail.com> (raw)
In-Reply-To: <m2ty45is1j.fsf@gmail.com>
On Sun, Jan 8, 2012 at 18:27, Aaron Ecay <aaronecay@gmail.com> wrote:
>> +(defun w3m-region (start end)) ;; From `w3m.el'.
>
> What is the purpose of the above line? If it is to make the compiler
> aware of the function, you should use ‘declare-function’ instead. Defun
> will erase the original definition of the w3m-region function.
Indeed, it's to make the compiler aware of the function. I followed
the example of notmuch-show.el (defvar w3m-current-buffer, line 391),
but it sounds like declare-function is a better way to accomplish
this. I haven't written a whole lot of emacs lisp, so thanks for the
tip.
Given David's comments about requiring w3m instead it might be moot,
but if not I'll make this change for the next version.
next prev parent reply other threads:[~2012-01-10 1:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 7:52 [PATCH 0/4] Quoting HTML-only emails in replies redux Adam Wolfe Gordon
2012-01-08 7:52 ` [PATCH 1/4] test: Add broken test for the new JSON reply format Adam Wolfe Gordon
2012-01-08 7:52 ` [PATCH 2/4] reply: Add a " Adam Wolfe Gordon
2012-01-14 20:58 ` Jani Nikula
2012-01-08 7:52 ` [PATCH 3/4] man: Update notmuch-reply man page for JSON format Adam Wolfe Gordon
2012-01-08 7:52 ` [PATCH 4/4] emacs: Use the new JSON reply format Adam Wolfe Gordon
2012-01-09 1:27 ` Aaron Ecay
2012-01-10 1:59 ` Adam Wolfe Gordon [this message]
2012-01-09 8:50 ` David Edmondson
2012-01-10 2:10 ` Adam Wolfe Gordon
2012-01-10 7:25 ` David Edmondson
2012-01-12 8:33 ` Dmitry Kurochkin
2012-01-12 12:07 ` David Edmondson
2012-01-12 13:36 ` Tomi Ollila
2012-01-12 13:43 ` David Edmondson
2012-01-15 21:19 ` Adam Wolfe Gordon
2012-01-09 1:36 ` [PATCH 0/4] Quoting HTML-only emails in replies redux Aaron Ecay
2012-01-10 1:53 ` Adam Wolfe Gordon
2012-01-15 9:26 ` David Edmondson
2012-01-16 7:38 ` Aaron Ecay
2012-01-16 8:39 ` David Edmondson
2012-01-16 19:29 ` Jameson Graef Rollins
2012-01-16 22:31 ` Aaron Ecay
2012-01-16 22:42 ` Adam Wolfe Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMoJFUu=vNcud1HpSDE9tapd8XA+HXQTD9z3_zhH-zA3EqMXqQ@mail.gmail.com' \
--to=awg+notmuch@xvx.ca \
--cc=aaronecay@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).