From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 3D9E6431FD0 for ; Mon, 9 Jan 2012 18:10:51 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eiXeBZR5sOiT for ; Mon, 9 Jan 2012 18:10:50 -0800 (PST) Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 5965D431FB6 for ; Mon, 9 Jan 2012 18:10:50 -0800 (PST) Received: by eaai1 with SMTP id i1so3019612eaa.26 for ; Mon, 09 Jan 2012 18:10:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.156.219 with SMTP id y27mr7919338bkw.71.1326161448804; Mon, 09 Jan 2012 18:10:48 -0800 (PST) Received: by 10.205.33.73 with HTTP; Mon, 9 Jan 2012 18:10:48 -0800 (PST) X-Originating-IP: [12.50.241.130] In-Reply-To: References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca> <1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca> Date: Mon, 9 Jan 2012 19:10:48 -0700 Message-ID: Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format. From: Adam Wolfe Gordon To: David Edmondson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 11 Jan 2012 18:03:20 -0800 Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2012 02:10:51 -0000 Hi David, Thanks for the review. Most of the things you've suggested are easy changes, and I think obvious improvements, so I'll change them for the next version. A bit of discussion on the more involved things below: On Mon, Jan 9, 2012 at 01:50, David Edmondson wrote: > On Sun, =A08 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon wrote: >> +(defun w3m-region (start end)) ;; From `w3m.el'. >> +(defun notmuch-mua-quote-part (part) >> + =A0(with-temp-buffer >> + =A0 =A0(insert part) >> + =A0 =A0(message-mode) >> + =A0 =A0(fill-region (point-min) (point-max)) >> + =A0 =A0(goto-char (point-min)) >> + =A0 =A0(perform-replace "^" "> " nil t nil) >> + =A0 =A0(set-buffer-modified-p nil) >> + =A0 =A0(buffer-substring (point-min) (point-max)))) > > Couldn't all of this be done directly in the reply buffer? Indeed, it could, I just hadn't thought of it. I'll do this for the next version. > Using w3m means that you should `require' it. What happens when a user > doesn't have it? (Either the elisp or the command.) This was my initial thought, but when I looked at notmuch-show.el, which uses w3m features, I noticed that it doesn't have a require. To be clear, this patch requires w3m.el (not just the w3m binary), which I don't think anything else in notmuch does. In the previous version I had a customize variable specifying whether to quote HTML parts, which meant that if the user could set the customize variable to false and everything would work without w3m.el. I'd like not to introduce a new prerequisite, so if there's a way to make w3m.el optional that would be my preference. Can you provide some guidance on this? --=20 Adam Wolfe Gordon