From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aL+CFJbZiGBZ/QAAgWs5BA (envelope-from ) for ; Wed, 28 Apr 2021 05:42:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 5/k5EJbZiGCTRAAAbx9fmQ (envelope-from ) for ; Wed, 28 Apr 2021 03:42:14 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7F7B01A2BE for ; Wed, 28 Apr 2021 05:42:13 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5D33327168; Tue, 27 Apr 2021 23:42:10 -0400 (EDT) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by mail.notmuchmail.org (Postfix) with ESMTPS id 19DB227167 for ; Tue, 27 Apr 2021 23:42:07 -0400 (EDT) Received: by mail-wm1-x336.google.com with SMTP id m5so6097936wmf.1 for ; Tue, 27 Apr 2021 20:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sC9syO87hZb+6p/Q8A29ikDEdnfntpwS252Za4WLgeg=; b=Ow0Xi5lL4XO7qhrVcBoTWxWiT+n9PVK7cvkrzeBC+EPF8lVnSgMzYK3HkQwp2t6E3I 0VegR5KqZDeU1hjvnoPkgY9Cd8Of2wRxUvfj/ZME+cr2Ylax7DkJAOXBLZKDOjWdvETN vRhTDuaCU6Q6+leQwzG18SdLVO8OkiKLIBa4q8HBFsbqS/XdBIZvshjX05lBZZmSWoyN nUEQsQWZ1FEvH4glcDLjnPc/eAedCOK9hfb/aMsRpavbiMempW4zMEoUF9eDvmiL9lm/ V1iL2FcNlfn7FYJ4Y4uSYoVoduI+EsJWzx0sXFeizdNQ4bY3suAfVktsLmzf2op2R5FZ AjSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sC9syO87hZb+6p/Q8A29ikDEdnfntpwS252Za4WLgeg=; b=GShG9TEOyMJsHQ0j6xjXgeHXadr24HXKybMYlulSgnPYfWaVv/onJQeCC7loqLS7pa 3AZEW+Ow7J4tGLv9nzgdI6mvTVvvROR/+ZBTOQJZLqoJ2fli/fJVqPYnaoTAR6lJQwT2 Uux47DkOg989DfWv3vgiXWNKM41h4V9VLuFHq6PIN5OP1wk7pHGI2UNorQOauRtaW24p 3KJeHfhmLBCaNpnoo8giPoOQ+uu/eEYDZOp0SQ2aJgFjkZIxNNhXGiKpcnImc6bfkK7k YjbcMpSfJ9b3dqjC1MIt4UkUaBdxv0/yC64V69c+InyO97PxiFfO4e67cs2i6Ss5K2ay cNSA== X-Gm-Message-State: AOAM531oihdTmt/p6LWL9dUZ4q8Nygns6PcNKGLGTXIZ18k03XmsZDd6 2n4dccbNu0w+Pz6WFtg1g3tpaerGK/hlIJgNobo= X-Google-Smtp-Source: ABdhPJzNRKw7h3lPua3JgbR13qlQxATTkkbjY5tEXaMOn8mNHjmcIZ4r5P43o5zE93cMMKw0BHHQEwh17pJkZdC+Z44= X-Received: by 2002:a1c:f20e:: with SMTP id s14mr1741026wmc.100.1619581325061; Tue, 27 Apr 2021 20:42:05 -0700 (PDT) MIME-Version: 1.0 References: <20210216234316.20990-1-juloo.dsi@gmail.com> <20210216234316.20990-2-juloo.dsi@gmail.com> In-Reply-To: <20210216234316.20990-2-juloo.dsi@gmail.com> From: Felipe Contreras Date: Tue, 27 Apr 2021 22:41:54 -0500 Message-ID: Subject: Re: [PATCH 2/2] Vim: Ensure that every queries respect excluded tags To: Jules Aguillon Message-ID-Hash: 5QHN4VI7N2KB4FGH3BSXT7TAXZGIUQLY X-Message-ID-Hash: 5QHN4VI7N2KB4FGH3BSXT7TAXZGIUQLY X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619581333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=W2788HWbsqKCpoczwsj1KNiST+vI5wS/8+uIKcC9kbo=; b=BGBiPevGosKKAX+b7Sm/g796yJ1GjwdYx7tG1pA0P83y0QW7f9ovopv7M2ihI/ziwc+zNy i4314ytJ1CRRqnK9xtFjkWlxE2mf4Lvj6WtT7IazDJnXnjinAbkzPNiTII1GgmsZI+sebn dZ8rx0xwTiSoYk1Yx0BqScuunrWz7kW4bEk8+dFzUuOpAfO+0zSq1gHMzytWOgob7uEAiH aFaheoo6W9lKPHAFNrAe46kcyPPEQY4q5nowPUyAf3qKfMPaz9NOQjLpdTNSrXVYOICH9b N7Y0JvxF0MPzHoEkjjJPm7DYZ0UOTmAr7TXblnnS0BEQCO8VjIvft0yEbVgIjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619581333; a=rsa-sha256; cv=none; b=c0WAkYOx2r9Qyv5Z+TtXwbBktAaDnbbJFtd95Y4SkLwmWMQCMJ1uqicvSYsQrMYKCyKJnn FyJpbv7GDPZ3aYKZQHKOt20OKZkHBmxqEQK1vfRHnr0QmzDbZGs9RmRTFjzISxpbdIBoV7 q9v45ZYEFnGiM201u2tFOZK0mAxzPApeX8lZyDmFPHtTCnBilz0D6AqS7mbCbSwrOzfBFO Dljiv92OFn7vFKieO59N4thlAGA1IYneSbHv/ZZKw7Rc9sY0GR4m+9ruqm/EDIbcLWP6S/ em6zzBs8NT6PWyohvt9RHRHl1DR+k/6+irrHPhue0PosvJ0G5buSusMUyTcVTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=Ow0Xi5lL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=Ow0Xi5lL; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7F7B01A2BE X-Spam-Score: -1.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: VKUY7PkdULgL On Tue, Feb 16, 2021 at 5:43 PM Jules Aguillon wrote: > > This makes sure that the bug solved by the previous commit won't happen again > and remove some dupplication. > This shouldn't have any side effect. At least Aaron D Borden did mention some issues with this approach [1]. >From my cursory look at this patch this would cause the do_tag() function to skip excluded tags, therefore you couldn't do for example "-delete". I think the query() helper could be extended to make it easier to pass excluded_tags, but this is not the way. Cheers. [1] https://github.com/felipec/notmuch-vim/pull/7 -- Felipe Contreras