From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B8F52431FAF for ; Mon, 14 Oct 2013 22:25:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bh8MR9RGljCH for ; Mon, 14 Oct 2013 22:25:14 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4D3F0431FAE for ; Mon, 14 Oct 2013 22:25:14 -0700 (PDT) Received: by mail-lb0-f181.google.com with SMTP id u14so6265070lbd.26 for ; Mon, 14 Oct 2013 22:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=uTyIQChw6wtzT7kCJZ4gWdK7TioURhL2Leg3HhNy2O8=; b=CDesS8IXRCBp+/MU26M5vyGJO8ncT0Ec5cw5iZ8g1kQXYUlqM3Hx5rsArmUEGptaDr UkG3Fxu1SJ0k5U80At81NfyVlY4WVuK5gMJ+hiUd5opu2tVTsAD3pDF58aivGhboQydl pwmSc02PpJgAAtpErh+xZ/64dEru74WGvHOhx2KRx1Cv2j+mo/Uadwe0XKIPX3GT9jd6 fjBYzsLm358NcrSA+RmO3PzKr24YuA2DcZbcyhwG5XijJ/Tt8MmnQ8B3mDfHtP1yON+3 B2/xPlaqSk77pJp2BtuzU3+O+84ZeV5sVebuTy/bnz7FwXu9WrMK+ryFQ1c4w6cGr8+A SFlA== MIME-Version: 1.0 X-Received: by 10.152.44.225 with SMTP id h1mr34577848lam.15.1381814711298; Mon, 14 Oct 2013 22:25:11 -0700 (PDT) Received: by 10.114.91.230 with HTTP; Mon, 14 Oct 2013 22:25:11 -0700 (PDT) In-Reply-To: <87txgpv16s.fsf@zancas.localnet> References: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com> <87txgpv16s.fsf@zancas.localnet> Date: Tue, 15 Oct 2013 00:25:11 -0500 Message-ID: Subject: Re: [PATCH 0/3] General fixes From: Felipe Contreras To: David Bremner Content-Type: text/plain; charset=UTF-8 Cc: "notmuch@notmuchmail.org" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 05:25:18 -0000 On Thu, Oct 10, 2013 at 6:02 AM, David Bremner wrote: > Felipe Contreras writes: > >> Felipe Contreras (3): >> query: bind queries to database objects >> ruby: allow build with RUNPATH >> ruby: bind database close()/destroy() properly > > Hi Felipe; > > I agree with the discussion on IRC that the change in the first patch > makes sense. > > It would be nice to have a bit more explanation in the commit message of > the second message; at least to point out that (iiuc) this is not a > really a ruby specific thing, just a standard ld.so feature. Yes, that is true, and an option libnotmuch.so already uses, so I thought it made sense that Ruby's notmuch.so used it as well. -- Felipe Contreras