From: Felipe Contreras <felipe.contreras@gmail.com>
To: David Bremner <david@tethera.net>
Cc: "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>,
Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH 2/2] ruby: enable garbage collection using talloc
Date: Sat, 26 Jun 2021 14:07:17 -0500 [thread overview]
Message-ID: <CAMP44s2BGRtR0NMT-hVm7c-=+MtHU0JPOmKxq8AzVmD9R8SQaQ@mail.gmail.com> (raw)
In-Reply-To: <871r98u6he.fsf@tethera.net>
On Fri, Jun 11, 2021 at 3:54 AM David Bremner <david@tethera.net> wrote:
>
> David Bremner <david@tethera.net> writes:
>
> > Felipe Contreras <felipe.contreras@gmail.com> writes:
> >
> >> We basically steal all the objects from their notmuch parents, therefore
> >> they are completely under Ruby's gc control.
> >>
> >> The order at which these objects are freed does not matter any more,
> >> because destroying the database does not destroy all the children
> >> objects, since they belong to Ruby now.
> >>
> >
> > I guess from a purist point of view this is a kind of layering
> > violation, since the use of talloc is purportedly an internal
> > implementation detail of the library. Still, I think it's a reasonable
> > approach given that the ruby bindings are maintained as part of notmuch,
> > and we are not very likely to abandon talloc.
> >
>
> One issue to double check: in a few places we explicitely _don't_ use
> talloc. What happens when those objects are passed to talloc_steal?
Seems like talloc aborts. Are there any of such objects?
--
Felipe Contreras
next prev parent reply other threads:[~2021-06-26 19:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 19:39 [PATCH 0/2] ruby: enable garbage collection Felipe Contreras
2021-05-17 19:39 ` [PATCH 1/2] ruby: create an actual wrapper struct Felipe Contreras
2021-07-18 22:58 ` David Bremner
2021-05-17 19:39 ` [PATCH 2/2] ruby: enable garbage collection using talloc Felipe Contreras
2021-06-11 0:46 ` David Bremner
2021-06-11 8:54 ` David Bremner
2021-06-26 19:07 ` Felipe Contreras [this message]
2021-06-26 19:54 ` David Bremner
2021-06-26 20:05 ` Felipe Contreras
2021-06-26 18:56 ` Felipe Contreras
2021-06-26 19:56 ` David Bremner
2021-05-22 10:49 ` [PATCH 0/2] ruby: enable garbage collection David Bremner
2021-05-28 3:10 ` Felipe Contreras
2021-06-26 20:07 ` [PATCH] perf-test: add ruby test Felipe Contreras
2021-07-18 22:54 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s2BGRtR0NMT-hVm7c-=+MtHU0JPOmKxq8AzVmD9R8SQaQ@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).