From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yDMrHzkOq2AvRgAAgWs5BA (envelope-from ) for ; Mon, 24 May 2021 04:23:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id EBbJGjkOq2DtdQAAbx9fmQ (envelope-from ) for ; Mon, 24 May 2021 02:23:53 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7B2213751 for ; Mon, 24 May 2021 04:23:52 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 116192AB29; Sun, 23 May 2021 22:23:50 -0400 (EDT) Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by mail.notmuchmail.org (Postfix) with ESMTPS id 6187B2AA00 for ; Sun, 23 May 2021 22:23:48 -0400 (EDT) Received: by mail-wm1-x32f.google.com with SMTP id f20-20020a05600c4e94b0290181f6edda88so3637497wmq.2 for ; Sun, 23 May 2021 19:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZJyarr5zCCGs+hkNBp36W5OtOpoopJTa7g55ODIEwPg=; b=YlqmatO7ApkQLjF1J8+7VIwmT/EY0kWc8PrYocN1bxH4fu6S2qhB3/gczhVB/mp3YL Sk5HYwH1o9Z8QxBC0R/NdAKs31ha18tXpXMmJ/DqUt/O6nlZnkIQnTU875TeaiZxVQUE tC18f38j+QpckQa0JeQw+1Y23YStSCIDRMnEzGN7DjIgJiJIKdfk+ml1TdxUrRmzK7q7 /P/VVpSGpZnqkaPUPXeXWdbipe5N0mUDuRaTdXwSh9yaGTz30o1bQOZUvG+Gzw0jNsPB e+m7llZe3/teDFzhOaWpj4RRDZ+eA5uircq5FJ3GlibaFHoWYtJgx7MDeSaOnH3NS6MR 9pPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZJyarr5zCCGs+hkNBp36W5OtOpoopJTa7g55ODIEwPg=; b=qyMnUvW4gNG6NjQOuZe1QOgsTyabnrnSdXHGqRr6mu2lf/GFkcJDAG1eboCalVBIeK lgfTGZd7joaKVxPAJPn/zQBlevaDE7eqzSDSD8mvCWr+c+agEQ0Yf2bWioS0MomsrZhL e17JfWoDwTVQwWKswTVLDZ5/UVC76rHuinm7vuRAe60vM+EwiOi7vxCc/5DNaE0IIp5Q KpbC5yUb7bxNv21cIO5FgfsDS40ZfupG6zrld2wD9GH9/jZDouBIG/1d+Z8KLPFrZj4f 2N1CkevezSGOWZxpaC8enyeFrgncwHD43Fka5O1R8c6Rqx//EIW++2XxSteJ002L301r YR3A== X-Gm-Message-State: AOAM532lK9YUql1g/2XHbyBVGDzH0dPiKgAsBGiIrY0wvrRodQW08hb0 E2mGUs0rbKOFQoI+fbXKkz6YsIIFJBji9nXJoEiPWntMJI8= X-Google-Smtp-Source: ABdhPJzyM1tyZuJQLloT8M9iihdmRlYCKa12tb1z+ObB1+LYH57q0D8eNGwIT+lQItYLMKRoGhfIi2O/uxFPYhfyTow= X-Received: by 2002:a7b:ce0f:: with SMTP id m15mr17650979wmc.55.1621823027034; Sun, 23 May 2021 19:23:47 -0700 (PDT) MIME-Version: 1.0 References: <20210501120448.484082-1-felipe.contreras@gmail.com> <20210501120448.484082-3-felipe.contreras@gmail.com> <8735udskei.fsf@tethera.net> In-Reply-To: <8735udskei.fsf@tethera.net> From: Felipe Contreras Date: Sun, 23 May 2021 21:23:36 -0500 Message-ID: Subject: Re: [PATCH 2/3] ruby: add keyword arguments to db.query To: David Bremner Message-ID-Hash: 72STDWCBSXPUZYEIUHSURXJUKV6KEL4P X-Message-ID-Hash: 72STDWCBSXPUZYEIUHSURXJUKV6KEL4P X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" , Ludovic LANGE , Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621823033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=btqU7vPE8X78i9WU332GNrhQPPhcxGHvo4dMOAnm0yU=; b=LYZVj1xOj+4q4WS7gsSp+PUkLGdMJECLuIfQsOeUdoSfZI7L+xbraeXrZD0ZTYaNYg3mUl H/gWY0gJNp6nL18bcjvO1itzYz2wQ3WSMM5qY6pYVVt50n4drJLpxoGXsqGc7MpsrHTRFK zdqfUnpf+tK3RF/2TRRyAKeYbVAZwUFRC0BDuOKJswCy1kDo01HfM9w6NsOmrP1Xq+nwOZ M9rJyMEFxPrst7LVZ+VRfT8itJDHL2DqHQYHy2Nz+++73sW49C8wGjvzzH2wnXhVn/0Skv ndSlyJ1RpS1lD8OglXnk0Xgw9luSJWOoPrUQLaMUinsQpoRvJOyFMgbnRLJaiw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621823033; a=rsa-sha256; cv=none; b=aIlAnfqBFLOPeMiU7rB3ciXS5HHV/e/lIQVE7+fGL39GhtQARy/YSvJSlQiHHjpUUkNFKu L2gWEI0evDoPToWKewWBWVmCaFFfPJel9b91qdkA6s2XmyCPb1Dah1Scnb+APgCnNEVUMP M4O6fxnXp9cRCCrP+8Fz59DBrErpqjmAbPhEWXBAKhljk2OHTDMRqgTzcI7Pkpa0JN3OxX d3BGUwv8+YeKUgL1tKpc0FWTQqt0Ur2dXNZrNJF4rMnHPnDnQ6w/08jXafvTIzlI9Yphky EBF+IrRerjWIhwOt/EGouzSu9jluTkTdSIZdVwu/Z/IBRzQonkSKFPc+1VavfQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=YlqmatO7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=YlqmatO7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: E7B2213751 X-Spam-Score: -0.97 X-Migadu-Scanner: scn0.migadu.com X-TUID: S7Van5QAI7+1 On Sun, May 23, 2021 at 7:29 AM David Bremner wrote: > > Felipe Contreras writes: > > > That way we don't need pass them to the query object ourselves. > > LGTM, but when I tried to resolve the conflicts I messed something up > and the ruby sort test(s) started failing. Rebase please? Not sure what happened there, my rebase happened without conflicts. -- Felipe Contreras