From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aDW9DpAfj2BCIgAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 23:54:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8DdGCpAfj2DmAwAAbx9fmQ (envelope-from ) for ; Sun, 02 May 2021 21:54:24 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83A03164EC for ; Sun, 2 May 2021 23:54:23 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 0B850271D5; Sun, 2 May 2021 17:54:20 -0400 (EDT) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by mail.notmuchmail.org (Postfix) with ESMTPS id C460420017 for ; Sun, 2 May 2021 17:54:17 -0400 (EDT) Received: by mail-wr1-x432.google.com with SMTP id v12so3585540wrq.6 for ; Sun, 02 May 2021 14:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pbY2+dSw7KW+ImnBz1ADFdkHOwpzT6B21dH/ZBf0sDE=; b=VSQepYwJ8QWdIgtG+a2umTFebZcEw/ZHuBa0VGm01Q5M636YdbS+YYalTZ81ehTKQm hexGX5K2uidE8RfxpeV+a/eVAD9Iz7af9dQ1ePp5TMh1QB3QJwMH2CjFhpvgVw2nw5j8 jk/RYXuV3tMskpsdo+U6Tdlmi2B47mtFHVky9U4m5gjZaTE3E5OFPBGkFAxZ3j489SzK E9DXL6wzz+S/4aa2aEfz12uxgCNdL1D2LpZaGhzd/ZIJ44PGEBLOJXH32z2dkcnuR9nC YZ/AjOtXYltGcYxlfYOWNMginnVndJJoZmZeTcfxb4S9UM29ibJczTFiCp/DpLKij72y a4eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pbY2+dSw7KW+ImnBz1ADFdkHOwpzT6B21dH/ZBf0sDE=; b=Y94L755yLml+fTv+NBAf+anWke0eZU4gm4JPW+mE/YZruGGnaZy3wAPa9niIRhE3Gn 3p9FezWxkUK/pAvU8XtCkTtfTK84iOizbqVbPLVM6xFtNXLP7iXJMQmA49cZn0ylB65M RmkaakoXxrz8zUBXurlywiDMNAb+0OrFGa8qCfh8O9TUp7olvb/IjruBmvUvstyd7Shk GwREERPpBomdoTByL1DGaDOzqa1GaFC5ivkAVDzE/tHHsqzD5tiJfTQ8KgWEDRe88KM/ 3R4qs2fX71coHMpfiT5IRXV9LRERnK/1gEOatr9Pf09b6AcYQWVpNDzE8DqK4ezl8nGD 7e1A== X-Gm-Message-State: AOAM530OPJ5MXDV6D1V1LhJzZQtYVJRg9lol4wn43WaKn1F6JUsYhC2E PvOH0SpKPWZLpADJ/TI2OKhpUOu0+G6fkxaGe0yAbo+tUes= X-Google-Smtp-Source: ABdhPJzRgSXUFILjEjrlI84wCCa3d+fzO0cnqNZWxx0PEQUjjNi5xffVZksy3J+CSv37YsYYJBXlu0gmgHS7/p6uoyI= X-Received: by 2002:adf:f80a:: with SMTP id s10mr20183102wrp.319.1619992450297; Sun, 02 May 2021 14:54:10 -0700 (PDT) MIME-Version: 1.0 References: <20210501115923.483816-1-felipe.contreras@gmail.com> <20210501115923.483816-6-felipe.contreras@gmail.com> <8735v5o0u6.fsf@tethera.net> In-Reply-To: <8735v5o0u6.fsf@tethera.net> From: Felipe Contreras Date: Sun, 2 May 2021 16:53:59 -0500 Message-ID: Subject: Re: [PATCH 5/9] test: ruby: simplify test_ruby() To: David Bremner Message-ID-Hash: 4ZXSL4ZF6SHHWV4KCQ7A25HRNLWFFZFL X-Message-ID-Hash: 4ZXSL4ZF6SHHWV4KCQ7A25HRNLWFFZFL X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619992463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=MYS0cca4eDKuZjbvvAxBOJjfhDhmBPkbKeMXU1sLCxc=; b=DMT0xP20xHewHgYTCAeYwIFioTSx0GsjMYWM2Y6BUdw6zogigCWJu0N5ef68uywCHlZUhx 7tsB8YFsUzOG1faipR1PNbwlaha4PmofCXg9RUyaZcP/dzg4Rtsd90h7q9Ue/5mGg2O25e F6LWmzE3XShhG/7kcX5LGunfSRjD3EmvAx2IYMqptawHaGgAwCAZ9vOd8UpTe1hZDYt+gH tKjoJq2ApTt3fv+6AdnB79D9TH2cYiM7ZG2iFAJVPZM1Wn3WCOjDXxCSyXQ0Y88TeI3XDr 4/FNdEVnadTlKUrm+SFB57HPwtH5zyP5IreEan9+zLyl+1rGjVJGLuqcDKcPqQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619992463; a=rsa-sha256; cv=none; b=bMtucyRnuy1iAqCe8kbtKIwkAHCPeWGqjr/6zy0tpquo6dEu9MfaTrsO4c3iTgWiINXyNj kS2RqTnykNMWbTvNpKzQhTBLNJjGV6jS1Qx6+E1uy/Ji+ytQ1J2wgdz4iZ3KfSBzxoHkEa R7PldR/QLIg8ctUpkXQMWnUKrr3P6FkHIjpAUf07gUBRhyHO3nKNdAAkrl6FMsK4fBfn0e BCTXjzfYD1WdbnJbyPVFQFs5s+4uXOUWTifmmRIglYpH5KnyklENghgRWpKOKJXqWBjyKa s8DLPWGZawD67lurMa/W8192zvSKV5ty5ixzAXadWp2XxM0JS6qllcb+nsr6qA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=VSQepYwJ; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=VSQepYwJ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 83A03164EC X-Spam-Score: -1.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: gcHCSZLto51H On Sun, May 2, 2021 at 6:02 AM David Bremner wrote: > > Felipe Contreras writes: > > > We always do test_expect_equal_file, so do it in test_ruby() directly. > > > > The only subtest where we don't (get non-existent file) can be easily > > modified. > > I'm slightly hesitent since every other test ends with test_expect_*. > OTOH it is self contained within this one file so I guess I can live > with this change. The test could be named test_ruby_expect and be passed the EXPECTED file, or something. -- Felipe Contreras