From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sO3iM5zYk2BTPAEAgWs5BA (envelope-from ) for ; Thu, 06 May 2021 13:53:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id APlyL5zYk2ANIgAAbx9fmQ (envelope-from ) for ; Thu, 06 May 2021 11:53:00 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 640C81CDB6 for ; Thu, 6 May 2021 13:53:00 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C9B5F2716D; Thu, 6 May 2021 07:52:56 -0400 (EDT) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by mail.notmuchmail.org (Postfix) with ESMTPS id 2833327167 for ; Thu, 6 May 2021 07:52:54 -0400 (EDT) Received: by mail-wr1-x434.google.com with SMTP id h4so5278430wrt.12 for ; Thu, 06 May 2021 04:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K31G5PH5+1z0Hq+QqcNLP2Agpur4dhckKDcHHXY3VkM=; b=stnusK/8B76VGV3vuXlPQ4gtB5VjktSZJl3lehJCG+yzJFQbLVdAZQa5c52GyUrq2L HAvAxXzCwxcZHWD49xciqaA358Zr41UbJN11A6GmuqKzhTJWOG6H6j3WSUWdbQhTtpRt /2k8Wm12MV+meMqFEGUXAqq5dfiS10rlAaevr1I7KaShE0VBagbCRZdA9oAU3dg0z5+T uURai9tFePfK8bDrq+eJ9Pnghf63FE7qLtngHk+urSjVnRLspZmNiTjcJDTK0N/+EB7i T6+5+R/zXKJVsXRcMXj+h9/ZKlq+6Ob39TdMyGoRivubGCVCop7asb25dxVuKh1f1cMC KA9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K31G5PH5+1z0Hq+QqcNLP2Agpur4dhckKDcHHXY3VkM=; b=tuVFqRTCFES8rw9DYYBgJRN7cKFdd4WM/pltz5+laIjco/DwmRxHr0R8KIDqBeZjtU gU0TlLOnt4doYLEzj6jRNbvO2h9W1vRfJVwpO6hMFsPtBiGUuTP+45eXMgXSBntTv/I1 aO+X57L17aKoDj7eaEQg3tN6ajfQX4kQ8aVvEn6l9SkGKTDR9ih0nVQ1+lwu9kEGriBf MmeZ+YpUidKWfho2x8yS+fFmyZQxcJ58zGAOkw6yGCD0VXGaLowM/NJkscKlJ0MnpMuZ 1/3sx7a3HF7FPHXxgG8GsIvApXq1TnJTpIaA0o11dfPJqdy3nTiRg8PIHbAulaF8KA0k iX/w== X-Gm-Message-State: AOAM533OePMC8idkauk61NmtuptkmsgFph9HfX/u7DCPPX9QcuTk/zq7 /IlWBoaUBCirLAE/oHfM8SnsdlSohopWZhYF2mo= X-Google-Smtp-Source: ABdhPJx6WtjwqSjdAGw0/AEaczTmPvAe6mqaFvebuYmM21OgZd3/0MGKFjThtWTVxcY0IpNPVoUg8ZJgEmE1BEF+f5o= X-Received: by 2002:adf:c002:: with SMTP id z2mr4682349wre.100.1620301967138; Thu, 06 May 2021 04:52:47 -0700 (PDT) MIME-Version: 1.0 References: <20210501115923.483816-1-felipe.contreras@gmail.com> <20210501115923.483816-8-felipe.contreras@gmail.com> <87v981mm1r.fsf@tethera.net> <878s4slspy.fsf@tethera.net> In-Reply-To: <878s4slspy.fsf@tethera.net> From: Felipe Contreras Date: Thu, 6 May 2021 06:52:36 -0500 Message-ID: Subject: Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms To: David Bremner Message-ID-Hash: N3J5GR7SALEDLFVY3TQRPMXQPATMYY3A X-Message-ID-Hash: N3J5GR7SALEDLFVY3TQRPMXQPATMYY3A X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Tomi Ollila , "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620301980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LBn14aJUYHzuSC9pK9o5iwNJkeXmMb3f8kGwPk8CYKU=; b=QluMuhhx7gpnoIVI/a1vXKJ0OLx+Ud/UsRN6o9pETuv5Vufcq6TSQPzLr+z0S72BfqsRV4 6zXqaUWwlV0c2XrEecYAjst33nj/wkCpL2YhVBGMARkZU8E3durEQv6X5o3kGSG6OgFrAc cUMFbh6HbWro7Mkb2sFUPTS4Y/EEbRhh2eIYtOwlkL/xhQ97fu+IrfgBFIDePNIAjgqd11 Qr9pA3oVnFuA173xr+uzVy9DAwHdVHk46AuZ/MTvNLocOEebfC3LHxrlVfl306tDCv0xmb OAiMLBeaUETZ0sd9n2jIj9r4BoTKiBRCTh/Z0tUMkQVw/NX40nmt/E5SB4UQ9w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620301980; a=rsa-sha256; cv=none; b=KN3/amXHlwQ8PZAkHBqb11W23CC1WTkw80ed7jRrpsO9e9cieBlD9g6HlbIB4jawtg1uAM evcowbaFOEiqult6Iac4lkRa08Jtzc2c5WgNriLsF/Er21vFz2b4Mft8wFvm0Ny5eeQymc RuPNHO51iQMzJVhJMMavFx356lyCRJR9eHievPYLbKbOq6oLf+4m4QjBh1jQFHripefpLo qXocAKHshKU/sPmevpjrKxVNxVyYNE9oG36RIgTn4nuNiW5zLfHgeVGHcZloI4dh+Jk0R2 XSEaoaxFEG6K3DI/gyBK/h6xzz0P1zGJU+6yDfwqvpcMzR5oIejGct2QRblv6g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b="stnusK/8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b="stnusK/8"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 640C81CDB6 X-Spam-Score: 0.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: z1M0bpAJPlw3 On Wed, May 5, 2021 at 5:29 PM David Bremner wrote: > Tomi Ollila writes: > > > > I am convinced that this is good change (like all the other changes > > in this series). > > > > Every now and then I encounter ruby code, and have seen syntax like > > `@q.search_threads.each do |t|` been used, so more exposure to that > > syntax is good thing (for everyone (IMO)) > > OK, I've applied the patch (and the others in the series). I have my > (already expressed) reservations, but I don't want to stand in the way > of progress on the ruby bindings. If you have reservations about the code, feel free to let me know and I would try to address them in further rerolls of the patch series. I'm a long term git contributor, so I'm used to several rounds of reviews, a bit of pushback isn't going to deter me. But at least the patches that you pushed I don't think could have any issues. Let's see the rest. Cheers. -- Felipe Contreras