From: Felipe Contreras <felipe.contreras@gmail.com>
To: David Bremner <david@tethera.net>
Cc: Tomi Ollila <tomi.ollila@iki.fi>,
"notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms
Date: Thu, 6 May 2021 06:52:36 -0500 [thread overview]
Message-ID: <CAMP44s0UEWCRZx=4Y2cT8ZDGSoFwzmJOSrabb4RYbaxbcgLryg@mail.gmail.com> (raw)
In-Reply-To: <878s4slspy.fsf@tethera.net>
On Wed, May 5, 2021 at 5:29 PM David Bremner <david@tethera.net> wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
> >
> > I am convinced that this is good change (like all the other changes
> > in this series).
> >
> > Every now and then I encounter ruby code, and have seen syntax like
> > `@q.search_threads.each do |t|` been used, so more exposure to that
> > syntax is good thing (for everyone (IMO))
>
> OK, I've applied the patch (and the others in the series). I have my
> (already expressed) reservations, but I don't want to stand in the way
> of progress on the ruby bindings.
If you have reservations about the code, feel free to let me know and
I would try to address them in further rerolls of the patch series.
I'm a long term git contributor, so I'm used to several rounds of
reviews, a bit of pushback isn't going to deter me.
But at least the patches that you pushed I don't think could have any issues.
Let's see the rest.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2021-05-06 11:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 11:59 [PATCH 0/9] test: ruby: several cleanups and simplifications Felipe Contreras
2021-05-01 11:59 ` [PATCH 1/9] test: move test_ruby() inside the only client Felipe Contreras
2021-05-02 10:49 ` David Bremner
2021-05-02 18:28 ` Tomi Ollila
2021-05-01 11:59 ` [PATCH 2/9] test: ruby: refactor test_ruby() Felipe Contreras
2021-05-02 10:50 ` David Bremner
2021-05-01 11:59 ` [PATCH 3/9] test: ruby: simplify MAIL_DIR check Felipe Contreras
2021-05-02 10:51 ` David Bremner
2021-05-01 11:59 ` [PATCH 4/9] test: ruby: simplify MAIL_DIR initialization Felipe Contreras
2021-05-02 10:56 ` David Bremner
2021-05-01 11:59 ` [PATCH 5/9] test: ruby: simplify test_ruby() Felipe Contreras
2021-05-02 11:02 ` David Bremner
2021-05-02 21:53 ` Felipe Contreras
2021-05-01 11:59 ` [PATCH 6/9] test: ruby: use much more standard puts Felipe Contreras
2021-05-02 11:03 ` David Bremner
2021-05-01 11:59 ` [PATCH 7/9] test: ruby: use much more standard Ruby idioms Felipe Contreras
2021-05-02 11:07 ` David Bremner
2021-05-02 19:00 ` Tomi Ollila
2021-05-05 22:29 ` David Bremner
2021-05-06 11:52 ` Felipe Contreras [this message]
2021-05-02 22:11 ` Felipe Contreras
2021-05-01 11:59 ` [PATCH 8/9] test: ruby: don't use instance variables Felipe Contreras
2021-05-02 11:08 ` David Bremner
2021-05-01 11:59 ` [PATCH 9/9] test: ruby: simplify output comparison Felipe Contreras
2021-05-02 11:09 ` David Bremner
2021-05-02 11:22 ` [PATCH 0/9] test: ruby: several cleanups and simplifications David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s0UEWCRZx=4Y2cT8ZDGSoFwzmJOSrabb4RYbaxbcgLryg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).