From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AHRAANO4fGBFxgAAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 00:55:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eOiMNdK4fGBOYAAAbx9fmQ (envelope-from ) for ; Sun, 18 Apr 2021 22:55:14 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9D8CE28048 for ; Mon, 19 Apr 2021 00:55:14 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1F9B126ACD; Sun, 18 Apr 2021 18:55:10 -0400 (EDT) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by mail.notmuchmail.org (Postfix) with ESMTPS id AF90B1F9D5 for ; Sun, 18 Apr 2021 18:55:07 -0400 (EDT) Received: by mail-wm1-x333.google.com with SMTP id n127so5366110wmb.5 for ; Sun, 18 Apr 2021 15:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UIrdeQQuvqUX1sLUKNsHq723wQpZQmcXPpTDsjT0g8o=; b=gyTS2xHe8jAiEtugQ2nCQ5WZ0MQdLob7SPPQexZ4X2P32khYUiuSrTkU6xmKj9xcyf z1HiKCqgrIdnXO90E0DH4qQVsZVI8GSA0s7atV0z8bmZXU0LrbZBhvfYm0UYMuypGj61 Mzc585QalcEgSqcevyLHvMr/8Ab1FhQwlLybWN0jkXqOvBAu9N7aECrgjTcMKhv7O0QE QiZv2reoAXM9xdYELglW+CIq8AK0DezPJbOWGFoxPRU45xqQYqvtJ1BllIgxReuRzZMV PCBPhAOwCS/7YEapZP8lQIrlvDiXI9dVw4BxtOJ3fDRN9P7zWUtogA20FdiErndAjkn0 a/ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UIrdeQQuvqUX1sLUKNsHq723wQpZQmcXPpTDsjT0g8o=; b=opOhe63/5Eh5sx++4yLJ7AiA6dYBVPbYafvqhn/I58bGeq4tmIcrZ8x58IKT2CYwra wYvvzdLb6GA8MFTzAiY56kze85rF/HX6wHq2nrN11K68PuTJF2/60mcjyMgj4FrPUfhg 4ehz1YcJpX15KbyH/sfrgfVgM2bNBeUdR+uWRCo1Oz25ZEMdNd/MQ9fXq3pbptzDERf8 2jGESM7le591/6QS6P+R8q1ZlOAhreGfCi64O0jAgVTgp/3YkVGvkhHD9nDvAs2yaqil 4XPZY16XrP8e4oNme2UrGjR2dplv1g3dVl9job8J6H63nKlOogv7yfNfZHCtviut23sB QTqA== X-Gm-Message-State: AOAM533aFpb5MLg3CKof8Dzsuj2q1RhuFBMBva3p9nc3uY14kDXSpkjQ QT7SAqu76GqsPIeVVdkU9v5uvoVCtxCgHjlxHSstG5axAqsJ+A== X-Google-Smtp-Source: ABdhPJz09VZ0j6h9ZCj1lJh1HJvOn1AeQrK5/3qKaQEgu/ZbMf56hvJJTHIth5sLwim/I9Yma66RJmDBWnlaQskAuIs= X-Received: by 2002:a7b:c4d5:: with SMTP id g21mr18107732wmk.55.1618786506534; Sun, 18 Apr 2021 15:55:06 -0700 (PDT) MIME-Version: 1.0 References: <20210416202731.72610-1-felipe.contreras@gmail.com> <875z0lcdbd.fsf@tethera.net> In-Reply-To: <875z0lcdbd.fsf@tethera.net> From: Felipe Contreras Date: Sun, 18 Apr 2021 17:54:55 -0500 Message-ID: Subject: Re: [PATCH] ruby: fix ruby 3.1 warnings To: David Bremner Message-ID-Hash: OQVC2IXRHCJE6UAK5GKV3AWNG27RX7E5 X-Message-ID-Hash: OQVC2IXRHCJE6UAK5GKV3AWNG27RX7E5 X-MailFrom: felipe.contreras@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618786514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=wvzVax3ufOnTJCENAtDGL0uLGvjmWo6v0oJvXdo9n6A=; b=NZ6gg+4lLgL2AJ8XzCAOQVBxy5llgGXMp2rjMQrS8uF5U+NLv3L0WdXoZyHvb6/8C5Zf0z Sb+H3fkjTZd8iD4ufnaxdmZ/EAVDJgLoWoU4/hIstqUQegmD2VQ+55F4P00h3p+VSLFJ+M d4KCzt2s+PIcCNa0LRc5gin8xAPaN/0QZY//RWR+xd9FedgRkKswd+0A3wKe5JyZQWOtdm GtWJT48nrEBgvpSOYe07cjjx3op9Ivx+2QrAaW8xggSdXMGMi5U3JtNQzIlHNAnn4Mdox9 wzCzR519d0AJuYc3v0A87UA6PWtdbo3M35JuJA+DGZea1W880aidGcGK6a8a7Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618786514; a=rsa-sha256; cv=none; b=PUHxu7mpnYTDzxS71ZhNupjTIYBZh51OvvSlKW3mm3JMuVL1uJ+yLsjxp9Q2FG/7kyvBJz ZnawLI8lHg/88j8Dj+Ms72LokIfTpMkspHfeUtpLHNM9JdyVuvkuz7Os8G4+E18s4HaaaF UfqJDrSjDfRhY7wN1XCzagY19+9gQz38h998rWSmT8r1MOZS3uGA2QxZBBRDU4oqCbnAxO hwrsbUbbmsyb9aMSSDHwCucNGGq9qvX2SZwcP2+m2AfWM8ydxZzVCk9K3qoabY4O8jYRxJ GTjl8U98sUWPRcmej5gIthVvY2Bim9xWMomlipPfBVDUYCJB2RE0afcBrHAZhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=gyTS2xHe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20161025 header.b=gyTS2xHe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9D8CE28048 X-Spam-Score: -0.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: TMrkziOrdvLW Hello. On Sat, Apr 17, 2021 at 7:20 AM David Bremner wrote: > Thanks for the patch. I have a couple of questions / comments > > - It doesn't apply against current master (5248f55d5f1). Can you rebase > it? Huh? That's precisely the commit I used as a base. It applies cleanly. > - What version of ruby is generating those warnings? I don't see it with > ruby 2.7. I guess that's not necessarily a blocker, as long as the > patched version still builds and runs with older ruby. Yeah, not a blocker. I'm using Ruby 3.0. -- Felipe Contreras