Re: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

Re: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

[Andreas Tolfsen]

+zack

What do I need to do to get this patch signed off and merged?

Re: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

[Stefano Zacchiroli]

On Thu, Apr 21, 2016 at 02:30:33PM +0100, Andreas Tolfsen wrote:
> +zack
> 
> What do I need to do to get this patch signed off and merged?

Sorry, I didn't get the rest of the thread. Can you (re) mail the patch
to me? I'll be happy to comment and/or signoff.

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader . . . . . @zacchiro . . . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

Re: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

[David Bremner]

Stefano Zacchiroli <zack@upsilon.cc> writes:

> On Thu, Apr 21, 2016 at 02:30:33PM +0100, Andreas Tolfsen wrote:
>> +zack
>> 
>> What do I need to do to get this patch signed off and merged?
>
> Sorry, I didn't get the rest of the thread. Can you (re) mail the patch
> to me? I'll be happy to comment and/or signoff.
>

I also can't see message that Andreas replies to in my copy of the list
archive or in gmane.

d

Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

[Stefano Zacchiroli]

On Thu, Apr 21, 2016 at 06:41:38PM +0100, Andreas Tolfsen wrote:
> The patch is straight forward.  You may want to just make the change
> yourself than jumping through the hoops of applying this.

Thanks Andreas for the suggestion; makes sense to me.

I just clarified in the commit message that, even if -w is dropped,
there is still use warnings in the script. New patch attached.

David: can you please push this to master?

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader . . . . . @zacchiro . . . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

[Stefano Zacchiroli]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On Thu, Apr 21, 2016 at 06:41:38PM +0100, Andreas Tolfsen wrote:
> The patch is straight forward.  You may want to just make the change
> yourself than jumping through the hoops of applying this.

Thanks Andreas for the suggestion; makes sense to me.

I just clarified in the commit message that, even if -w is dropped,
there is still use warnings in the script. New patch attached.

David: can you please push this to master?

Cheers.
-- 
Stefano Zacchiroli  . . . . . . .  zack@upsilon.cc . . . . o . . . o . o
Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o
Former Debian Project Leader . . . . . @zacchiro . . . . o o o . . . o .
« the first rule of tautology club is the first rule of tautology club »

[-- Attachment #2: 0001-notmuch-mutt-use-env-to-locate-perl-for-increased-po.patch --]
[-- Type: text/x-diff, Size: 815 bytes --]

From 3e27c59e6ab02fa652b35ce3a23e4d324ed69b6d Mon Sep 17 00:00:00 2001
From: Stefano Zacchiroli <zack@upsilon.cc>
Date: Thu, 21 Apr 2016 14:04:23 -0400
Subject: [PATCH] notmuch-mutt: use env to locate perl for increased
 portability

Note: this patch drops -w from the shebang line, but we still have
"use warnings" in the script, which is superior anyhow.

Thanks Andreas Tolfsen for the suggestion.
---
 contrib/notmuch-mutt/notmuch-mutt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
index b47b365..97fb2d8 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++ b/contrib/notmuch-mutt/notmuch-mutt
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -w
+#!/usr/bin/env perl
 #
 # notmuch-mutt - notmuch (of a) helper for Mutt
 #
-- 
2.8.0.rc3

Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from environment

[David Bremner]

Stefano Zacchiroli <zack@upsilon.cc> writes:

> On Thu, Apr 21, 2016 at 06:41:38PM +0100, Andreas Tolfsen wrote:
>> The patch is straight forward.  You may want to just make the change
>> yourself than jumping through the hoops of applying this.
>
> Thanks Andreas for the suggestion; makes sense to me.
>
> I just clarified in the commit message that, even if -w is dropped,
> there is still use warnings in the script. New patch attached.
>
> David: can you please push this to master?
>

done.

d