From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 0A7AD6DE11EC for ; Sat, 5 Mar 2016 03:09:56 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.01 X-Spam-Level: X-Spam-Status: No, score=-1.01 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.211, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C-7VoHa7zIzi for ; Sat, 5 Mar 2016 03:09:53 -0800 (PST) Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) by arlo.cworth.org (Postfix) with ESMTPS id 552A96DE1003 for ; Sat, 5 Mar 2016 03:09:53 -0800 (PST) Received: by mail-io0-f174.google.com with SMTP id l127so87885148iof.3 for ; Sat, 05 Mar 2016 03:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=pEUufX+qPgK4gq/qKOzp7VNH57/7prTS2Jc5oYWfvEs=; b=jr34ulQWwDvNV+Ep/maUbigO1+2BdOvfh+Y5eQEbv1kkqBd55ucfkEQcsddZacHIgw a2ZRHK3MhTPV735R5lZ5ZiG9FzEjKRCW45cGFXaQAn14zp7x1GALyKUVvxmYa2+Ikq2t 63loRiN4k8+Gulei+SrqqeW3Bbost+p3EZ2c2q/Es5b6HNbJ7/J5+yzV/13/ZeCJfSzg NvgkRajiwXspDvIypPtob0t7G4pUZe04vy+Y4IuykMKI1jPE49H98TprhloctiuM0m2F lyYzsuoDGTTi4CLGfrR6vnWpbbqSjkfi+XsdwmJ84WH2b88S2suv3btb3GhznxiKZ8YI 8mPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=pEUufX+qPgK4gq/qKOzp7VNH57/7prTS2Jc5oYWfvEs=; b=UDyF4MFcjCRg9Y6H/sXZav3PcgFBoiPItkOUsHnwGoVFCWzNU9SUoUuySHZ7f7wMCr WgEZ4Fkq2KKhqfcGs9X6JXVct4odE1iXhkrxAt0eSS8JGs6wVdVZ9iEwS3WyZ1PzXDAH RLTKbTacGhtjLQvClT/oyfKJLAbh1Ip5xkrb9eAktWoSH78bBfkhcostup1dI5t0NsAY Y2D5hNw8V5OmBXhaWYnYPU84QNIQpp8GYClJPLQllRGGFu51rfWEcEp68aV0Df1rAcLF VZXHTmzCkNsrqZb6YDDy6XxlSunUuRAUrVIyKngWDuCDspvuZsgBqYvc3LKQHInYkjdC iiMA== X-Gm-Message-State: AD7BkJLm1R3MGczWh60TvF1U/y6PXbMrgRJDGx8vhMcA/wzllKV/SybuSNFoLyDOI1kok0ykPvIEAHddyajQdQ== MIME-Version: 1.0 X-Received: by 10.107.136.79 with SMTP id k76mr12929288iod.50.1457176191306; Sat, 05 Mar 2016 03:09:51 -0800 (PST) Received: by 10.107.6.197 with HTTP; Sat, 5 Mar 2016 03:09:51 -0800 (PST) Received: by 10.107.6.197 with HTTP; Sat, 5 Mar 2016 03:09:51 -0800 (PST) In-Reply-To: <87h9glb367.fsf@qmul.ac.uk> References: <87mvqdmer2.fsf@gmail.com> <87k2lhmecn.fsf@gmail.com> <87h9glb367.fsf@qmul.ac.uk> Date: Sat, 5 Mar 2016 11:09:51 +0000 Message-ID: Subject: Re: use font-face instead of explicit colouring From: Sam Halliday To: Mark Walters Cc: notmuch@notmuchmail.org Content-Type: multipart/alternative; boundary=001a113ed2ee42148d052d4b4513 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Mar 2016 11:09:56 -0000 --001a113ed2ee42148d052d4b4513 Content-Type: text/plain; charset=UTF-8 That's a shame. Having light/dark alternatives are OK as a workaround but it's a shame this can't just all be done with faces. I don't see why there needs to be a string to face lookup map, why not just put the string in the face name? On 5 Mar 2016 11:00 a.m., "Mark Walters" wrote: > > Hi > > On Sat, 05 Mar 2016, Sam Halliday wrote: > > I should say that I am aware of the workaround, e.g. > > > > (setq > > notmuch-search-line-faces '(("unread" :weight bold) > > ("flagged" :inherit > 'font-lock-string-face))) > > > > but this must be applied per-user. If you removed this defcustom and had > > unread/flagged/other faces, then themes (such as darcula) would be able > > to provide sensible defaults out of the box. > > I am not sure I see how this would work without cluttering up the > customize options significantly. The notmuch-search-line-faces allows > selecting the face based on any tag (so for example I use different > colours for emails tagged "work", and tagged "waiting"). We could have > additional notmuch-search-line-unread-face which could then be used in > the above -- but now the user has two places to customize the same thing. > > How do you see this working? > > (We probably could make the default depend on light or dark theme to make > the default more usable.) > > Best wishes > > Mark > > > > > Sam Halliday writes: > > > >> [ text/plain ] > >> Hi, > >> > >> I use a dark theme and many of the colour choices of notmuch collide > >> with my theme. However, notmuch is explicitly adding information such as > >> "blue foreground" instead of using faces that I can customise. > >> > >> Could you please consider using faces instead of explicit colours? > >> > >> [ text/plain ] > >> > >> -- > >> Best regards, > >> Sam > >> [ signature.asc: application/pgp-signature ] > > > > -- > > Best regards, > > Sam > > _______________________________________________ > > notmuch mailing list > > notmuch@notmuchmail.org > > https://notmuchmail.org/mailman/listinfo/notmuch > --001a113ed2ee42148d052d4b4513 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

That's a shame. Having light/dark alternatives are OK as= a workaround but it's a shame this can't just all be done with fac= es. I don't see why there needs to be a string to face lookup map, why = not just put the string in the face name?

On 5 Mar 2016 11:00 a.m., "Mark Walters&quo= t; <markwalters1009@gmail.c= om> wrote:
Hi

On Sat, 05 Mar 2016, Sam Halliday <sam.halliday@gmail.com> wrote:
> I should say that I am aware of the workaround, e.g.
>
>=C2=A0 =C2=A0 =C2=A0(setq
>=C2=A0 =C2=A0 =C2=A0 =C2=A0notmuch-search-line-faces '(("unrea= d" :weight bold)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0("flagged"= :inherit 'font-lock-string-face)))
>
> but this must be applied per-user. If you removed this defcustom and h= ad
> unread/flagged/other faces, then themes (such as darcula) would be abl= e
> to provide sensible defaults out of the box.

I am not sure I see how this would work without cluttering up the
customize options significantly. The notmuch-search-line-faces allows
selecting the face based on any tag (so for example I use different
colours for emails tagged "work", and tagged "waiting")= . We could have
additional notmuch-search-line-unread-face which could then be=C2=A0 used i= n
the above -- but now the user has two places to customize the same thing.
How do you see this working?

(We probably could make the default depend on light or dark theme to make the default more usable.)

Best wishes

Mark

>
> Sam Halliday <sam.hallida= y@gmail.com> writes:
>
>> [ text/plain ]
>> Hi,
>>
>> I use a dark theme and many of the colour choices of notmuch colli= de
>> with my theme. However, notmuch is explicitly adding information s= uch as
>> "blue foreground" instead of using faces that I can cust= omise.
>>
>> Could you please consider using faces instead of explicit colours?=
>>
>> [ text/plain ]
>>
>> --
>> Best regards,
>> Sam
>> [ signature.asc: application/pgp-signature ]
>
> --
> Best regards,
> Sam
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org=
> https://notmuchmail.org/mailman/listinfo/notmuc= h
--001a113ed2ee42148d052d4b4513--