From: Austin Clements <amdragon@mit.edu>
To: Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results
Date: Fri, 4 Nov 2011 16:21:43 -0400 [thread overview]
Message-ID: <CAH-f9WvKpRVg+H8Xu-FG6pmeegS29Z5C7Bw7sDLRoRTHMM-NSg@mail.gmail.com> (raw)
In-Reply-To: <87obwwlsqo.fsf@nikula.org>
On Mon, Oct 31, 2011 at 6:07 PM, Jani Nikula <jani@nikula.org> wrote:
> On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
>> In order to push forward with this, though, I think we really need to
>> have a complete unit test for this new functionality. We usually like
>> to see units tests that describe and then test for the new functionality
>> you wish to add, followed by the patches that provide the new
>> functionality. Lots of good tests for new functionality being proposed
>> here shouldn't be too difficult to work out ahead of time.
>
> Right. I'd just like to make sure the approach I've taken (particularly
> patch 1 in the set as it touches the lib) is acceptable before spending
> time on testing and documentation etc. Indeed patches 1 and 2 changed
> fundamentally between v1 and v2 after some chats on IRC. If the comments
> now are favourable, I'll write the tests and documentation. (Though I
> guess I have to admit the tests would've been beneficial to me already
> now...)
The library interface looks perfectly reasonable and consistent to me.
My only concern would be that there's no way to return errors from
notmuch_query_count_threads, but notmuch_query_count_messages has
exactly the same problem.
Other than that, you missed a few spaces before parentheses.
next prev parent reply other threads:[~2011-11-04 20:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 21:18 [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results Jani Nikula
2011-10-31 21:18 ` [RFC PATCH v2 1/3] lib: add function to get the number of threads matching a search Jani Nikula
2011-10-31 21:18 ` [RFC PATCH v2 2/3] cli: add options --first and --maxitems to notmuch search Jani Nikula
2011-10-31 21:18 ` [RFC PATCH v2 3/3] emacs: support limiting the number of results shown in search results Jani Nikula
2011-11-04 20:54 ` Austin Clements
2011-11-06 20:57 ` Jani Nikula
2011-10-31 21:44 ` [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages " Jameson Graef Rollins
2011-10-31 22:07 ` Jani Nikula
2011-10-31 22:19 ` Jameson Graef Rollins
2011-11-04 20:21 ` Austin Clements [this message]
2011-11-01 12:30 ` David Bremner
2011-11-02 9:27 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH-f9WvKpRVg+H8Xu-FG6pmeegS29Z5C7Bw7sDLRoRTHMM-NSg@mail.gmail.com \
--to=amdragon@mit.edu \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).